* [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb @ 2026-06-16 5:27 Sam Day via B4 Relay 2026-06-19 15:10 ` Konrad Dybcio 0 siblings, 1 reply; 7+ messages in thread From: Sam Day via B4 Relay @ 2026-06-16 5:27 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, Sam Day From: Sam Day <me@samcday.com> These regulators are marked regulator-boot-on, but that doesn't guarantee they'll stay alive as long as the simplefb does. Adding the explicit supplies ensures that booting with MDSS disabled doesn't switch the panel off 30 seconds after boot. Signed-off-by: Sam Day <me@samcday.com> --- arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi index a6c2519a418d9..fc6ac8668a7bd 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi @@ -75,6 +75,9 @@ chosen { framebuffer: framebuffer { compatible = "simple-framebuffer"; memory-region = <&cont_splash_mem>; + vddio-supply = <&vreg_l14a_1p88>; + vci-supply = <&panel_vci_3v3>; + poc-supply = <&panel_vddi_poc_1p8>; format = "a8r8g8b8"; stride = <(1080 * 4)>; --- base-commit: 8d6dbbbe3ba62de0a63e962ee004afb848c8e3ac change-id: 20260616-sdm845-oneplus-simplefb-regulators-fc98c5dfd69e Best regards, -- Sam Day <me@samcday.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb 2026-06-16 5:27 [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb Sam Day via B4 Relay @ 2026-06-19 15:10 ` Konrad Dybcio 2026-06-19 23:15 ` Sam Day 0 siblings, 1 reply; 7+ messages in thread From: Konrad Dybcio @ 2026-06-19 15:10 UTC (permalink / raw) To: me, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel On 6/16/26 7:27 AM, Sam Day via B4 Relay wrote: > From: Sam Day <me@samcday.com> > > These regulators are marked regulator-boot-on, but that doesn't > guarantee they'll stay alive as long as the simplefb does. Adding the > explicit supplies ensures that booting with MDSS disabled doesn't > switch the panel off 30 seconds after boot. Why would you boot without MDSS if you want the panel to function? Konrad ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb 2026-06-19 15:10 ` Konrad Dybcio @ 2026-06-19 23:15 ` Sam Day 2026-06-29 14:24 ` Konrad Dybcio 0 siblings, 1 reply; 7+ messages in thread From: Sam Day @ 2026-06-19 23:15 UTC (permalink / raw) To: Konrad Dybcio Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel Hello Konrad, On Saturday, 20 June 2026 at 1:11 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > On 6/16/26 7:27 AM, Sam Day via B4 Relay wrote: > > From: Sam Day <me@samcday.com> > > > > These regulators are marked regulator-boot-on, but that doesn't > > guarantee they'll stay alive as long as the simplefb does. Adding the > > explicit supplies ensures that booting with MDSS disabled doesn't > > switch the panel off 30 seconds after boot. > > Why would you boot without MDSS if you want the panel to function? For my particular use-case [1] I'm trying to avoid taking over the display hardware entirely, and use simplefb until kexecing into the real kernel. In this case the user might halt in a pre-boot menu UI for a while. I can also imagine this being similarly useful for "recovery kernel" use-cases where again, it may not be desirable to assume control of MDSS/MDP/DSI blocks. [1]: https://github.com/samcday/pocketboot Regards, -Sam > > Konrad > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb 2026-06-19 23:15 ` Sam Day @ 2026-06-29 14:24 ` Konrad Dybcio 2026-06-29 22:39 ` Sam Day 0 siblings, 1 reply; 7+ messages in thread From: Konrad Dybcio @ 2026-06-29 14:24 UTC (permalink / raw) To: Sam Day Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 6/20/26 1:15 AM, Sam Day wrote: > Hello Konrad, > > On Saturday, 20 June 2026 at 1:11 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > >> On 6/16/26 7:27 AM, Sam Day via B4 Relay wrote: >>> From: Sam Day <me@samcday.com> >>> >>> These regulators are marked regulator-boot-on, but that doesn't >>> guarantee they'll stay alive as long as the simplefb does. Adding the >>> explicit supplies ensures that booting with MDSS disabled doesn't >>> switch the panel off 30 seconds after boot. >> >> Why would you boot without MDSS if you want the panel to function? > > For my particular use-case [1] I'm trying to avoid taking over the display > hardware entirely, and use simplefb until kexecing into the real kernel. In > this case the user might halt in a pre-boot menu UI for a while. > > I can also imagine this being similarly useful for "recovery kernel" use-cases > where again, it may not be desirable to assume control of MDSS/MDP/DSI blocks. > > [1]: https://github.com/samcday/pocketboot Can you handle this by adding a panel = <&display_panel> property under simplefb, pointing to the display panel defined in the same file? Konrad ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb 2026-06-29 14:24 ` Konrad Dybcio @ 2026-06-29 22:39 ` Sam Day 2026-06-29 22:51 ` Sam Day 0 siblings, 1 reply; 7+ messages in thread From: Sam Day @ 2026-06-29 22:39 UTC (permalink / raw) To: Konrad Dybcio Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel Hey Konrad, On Tuesday, 30 June 2026 at 12:24 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > On 6/20/26 1:15 AM, Sam Day wrote: > > Hello Konrad, > > > > On Saturday, 20 June 2026 at 1:11 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > > > >> On 6/16/26 7:27 AM, Sam Day via B4 Relay wrote: > >>> From: Sam Day <me@samcday.com> > >>> > >>> These regulators are marked regulator-boot-on, but that doesn't > >>> guarantee they'll stay alive as long as the simplefb does. Adding the > >>> explicit supplies ensures that booting with MDSS disabled doesn't > >>> switch the panel off 30 seconds after boot. > >> > >> Why would you boot without MDSS if you want the panel to function? > > > > For my particular use-case [1] I'm trying to avoid taking over the display > > hardware entirely, and use simplefb until kexecing into the real kernel. In > > this case the user might halt in a pre-boot menu UI for a while. > > > > I can also imagine this being similarly useful for "recovery kernel" use-cases > > where again, it may not be desirable to assume control of MDSS/MDP/DSI blocks. > > > > [1]: https://github.com/samcday/pocketboot > > Can you handle this by adding a panel = <&display_panel> property > under simplefb, pointing to the display panel defined in the same > file? No, that won't work because display_panel is a child of mdss_dsi0, which is a child of mdss. So if those nodes are disabled (which is what I'm trying to achieve), fw_devlink will defer probing simplefb. BR, -Sam > > Konrad > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb 2026-06-29 22:39 ` Sam Day @ 2026-06-29 22:51 ` Sam Day 2026-06-30 14:47 ` Konrad Dybcio 0 siblings, 1 reply; 7+ messages in thread From: Sam Day @ 2026-06-29 22:51 UTC (permalink / raw) To: Konrad Dybcio Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel Hi Konrad, On Tuesday, 30 June 2026 at 8:39 AM, Sam Day <me@samcday.com> wrote: > Hey Konrad, > > On Tuesday, 30 June 2026 at 12:24 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > > > On 6/20/26 1:15 AM, Sam Day wrote: > > > Hello Konrad, > > > > > > On Saturday, 20 June 2026 at 1:11 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > > > > > >> On 6/16/26 7:27 AM, Sam Day via B4 Relay wrote: > > >>> From: Sam Day <me@samcday.com> > > >>> > > >>> These regulators are marked regulator-boot-on, but that doesn't > > >>> guarantee they'll stay alive as long as the simplefb does. Adding the > > >>> explicit supplies ensures that booting with MDSS disabled doesn't > > >>> switch the panel off 30 seconds after boot. > > >> > > >> Why would you boot without MDSS if you want the panel to function? > > > > > > For my particular use-case [1] I'm trying to avoid taking over the display > > > hardware entirely, and use simplefb until kexecing into the real kernel. In > > > this case the user might halt in a pre-boot menu UI for a while. > > > > > > I can also imagine this being similarly useful for "recovery kernel" use-cases > > > where again, it may not be desirable to assume control of MDSS/MDP/DSI blocks. > > > > > > [1]: https://github.com/samcday/pocketboot > > > > Can you handle this by adding a panel = <&display_panel> property > > under simplefb, pointing to the display panel defined in the same > > file? > > No, that won't work because display_panel is a child of mdss_dsi0, which is > a child of mdss. So if those nodes are disabled (which is what I'm trying to > achieve), fw_devlink will defer probing simplefb. I apologize for spamming you with false assertions! I just realized that fw_devlink won't step in and enforce such probe deferral unless the property explicitly ends with -supply. However, I tried your suggestion and confirm that the LCD_VCI_3V + VDDI_POC regulators are still turned off by regulator_init_complete_work(). Since I've already embarrassed myself once today I'm not going to attempt to speculate as to why :) Cheers, -Sam > > BR, > -Sam > > > > > Konrad > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb 2026-06-29 22:51 ` Sam Day @ 2026-06-30 14:47 ` Konrad Dybcio 0 siblings, 0 replies; 7+ messages in thread From: Konrad Dybcio @ 2026-06-30 14:47 UTC (permalink / raw) To: Sam Day Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 6/30/26 12:51 AM, Sam Day wrote: > Hi Konrad, > > On Tuesday, 30 June 2026 at 8:39 AM, Sam Day <me@samcday.com> wrote: > >> Hey Konrad, >> >> On Tuesday, 30 June 2026 at 12:24 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: >> >>> On 6/20/26 1:15 AM, Sam Day wrote: >>>> Hello Konrad, >>>> >>>> On Saturday, 20 June 2026 at 1:11 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: >>>> >>>>> On 6/16/26 7:27 AM, Sam Day via B4 Relay wrote: >>>>>> From: Sam Day <me@samcday.com> >>>>>> >>>>>> These regulators are marked regulator-boot-on, but that doesn't >>>>>> guarantee they'll stay alive as long as the simplefb does. Adding the >>>>>> explicit supplies ensures that booting with MDSS disabled doesn't >>>>>> switch the panel off 30 seconds after boot. >>>>> >>>>> Why would you boot without MDSS if you want the panel to function? >>>> >>>> For my particular use-case [1] I'm trying to avoid taking over the display >>>> hardware entirely, and use simplefb until kexecing into the real kernel. In >>>> this case the user might halt in a pre-boot menu UI for a while. >>>> >>>> I can also imagine this being similarly useful for "recovery kernel" use-cases >>>> where again, it may not be desirable to assume control of MDSS/MDP/DSI blocks. >>>> >>>> [1]: https://github.com/samcday/pocketboot >>> >>> Can you handle this by adding a panel = <&display_panel> property >>> under simplefb, pointing to the display panel defined in the same >>> file? >> >> No, that won't work because display_panel is a child of mdss_dsi0, which is >> a child of mdss. So if those nodes are disabled (which is what I'm trying to >> achieve), fw_devlink will defer probing simplefb. > > I apologize for spamming you with false assertions! I just realized that > fw_devlink won't step in and enforce such probe deferral unless the property > explicitly ends with -supply. > > However, I tried your suggestion and confirm that the LCD_VCI_3V + VDDI_POC > regulators are still turned off by regulator_init_complete_work(). Since I've > already embarrassed myself once today I'm not going to attempt to speculate as > to why :) That's the way we all learn! Looks like the answer is 'because nothing grabs these regulators'.. At a glance, grabbing a regulator reference is strictly tied to a struct device (and its fwnode), so it's probably not so easy to make it.. Konrad ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-06-30 14:47 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-06-16 5:27 [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb Sam Day via B4 Relay 2026-06-19 15:10 ` Konrad Dybcio 2026-06-19 23:15 ` Sam Day 2026-06-29 14:24 ` Konrad Dybcio 2026-06-29 22:39 ` Sam Day 2026-06-29 22:51 ` Sam Day 2026-06-30 14:47 ` Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®