From: Stephen Warren <swarren@nvidia.com>
To: Olof Johansson <olof@lixom.net>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Russell King <linux@arm.linux.org.uk>,
Colin Cross <ccross@android.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: RE: [PATCH 03/10] arm/tegra: prepare clock code for multiple tegra variants
Date: Fri, 18 Nov 2011 12:18:40 -0800 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF1740D74F48@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <20111118190649.GB31678@quad.lixom.net>
Olof Johansson wrote at Friday, November 18, 2011 12:07 PM:
> On Thu, Nov 17, 2011 at 06:19:17PM +0200, Peter De Schrijver wrote:
> > Rework the tegra20 clock code to support multiple tegra variants :
> >
> > * remove tegra2_periph_reset_assert/tegra2_periph_reset_deassert. This
> > functionality should be in clock.c.
> > * compile tegra_sdmmc_tap_delay only on tegra20 as this feature will not
> > be available in future variants.
> > * don't export clk_measure_input_freq as its functionality is also available
> > using clk_get_rate().
...
> > @@ -403,10 +405,11 @@ void __init tegra_init_clock(void)
> > }
> >
> > /*
> > - * The SDMMC controllers have extra bits in the clock source register that
> > - * adjust the delay between the clock and data to compenstate for delays
> > - * on the PCB.
> > + * The SDMMC controllers on tegra20 have extra bits in the clock source
> > + * register that adjust the delay between the clock and data to compenstate
> > + * for delays on the PCB.
> > */
> > +#ifdef CONFIG_ARCH_TEGRA_2x_SOC
> > void tegra_sdmmc_tap_delay(struct clk *c, int delay)
> > {
> > unsigned long flags;
> > @@ -415,6 +418,7 @@ void tegra_sdmmc_tap_delay(struct clk *c, int delay)
> > tegra2_sdmmc_tap_delay(c, delay);
> > spin_unlock_irqrestore(&c->spinlock, flags);
> > }
> > +#endif
>
> Ifdeffing this out doesn't quite make sense. Better to do a #ifdef in the
> include file with an #else case that fills in an empty function. This
> needs to be abstracted differently for the two platforms anyway but
> that can be done separately from this. Does tegra3 have tap delay setup
> as well? (I don't have the TRM handy right now).
I vote just rip this function out altogether.
It isn't used in mainline, chromeos-2.6.38, chromeos-3.0, nor our internal
2.6.36 or 2.6.39 kernels.
Equally, I can't find any documentation of the register bits this code
touches in either Tegra20 or Tegra30 TRMs.
--
nvpublic
next prev parent reply other threads:[~2011-11-18 20:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 16:19 [PATCH v5 00/10] Add support for tegra30 and cardhu Peter De Schrijver
2011-11-17 16:19 ` [PATCH 01/10] arm/tegra: initial device tree for tegra30 Peter De Schrijver
2011-11-17 19:39 ` Stephen Warren
2011-11-18 18:49 ` Olof Johansson
2011-11-18 19:30 ` Rob Herring
2011-11-18 21:48 ` Olof Johansson
2011-11-18 22:03 ` Rob Herring
2011-11-17 16:19 ` [PATCH 02/10] arm/tegra: cleanup tegra20 support Peter De Schrijver
2011-11-17 16:19 ` [PATCH 03/10] arm/tegra: prepare clock code for multiple tegra variants Peter De Schrijver
2011-11-18 19:06 ` Olof Johansson
2011-11-18 20:18 ` Stephen Warren [this message]
2011-11-18 21:25 ` Olof Johansson
2011-11-18 21:38 ` Stephen Warren
2011-11-21 12:44 ` Peter De Schrijver
2011-11-17 16:19 ` [PATCH 04/10] arm/tegra: prepare early init " Peter De Schrijver
2011-11-17 16:55 ` Russell King - ARM Linux
2011-11-17 16:19 ` [PATCH 05/10] arm/tegra: rename tegra20 pinmux files Peter De Schrijver
2011-11-17 16:19 ` [PATCH 06/10] arm/tegra: prepare pinmux code for multiple tegra variants Peter De Schrijver
2011-11-18 21:41 ` Olof Johansson
2011-11-21 14:29 ` Peter De Schrijver
2011-11-21 17:24 ` Stephen Warren
2011-11-22 19:01 ` Olof Johansson
2011-11-23 3:22 ` Peter De Schrijver
2011-11-17 16:19 ` [PATCH 07/10] arm/tegra: add new fields to struct tegra_pingroup_desc Peter De Schrijver
2011-11-17 16:19 ` [PATCH 08/10] arm/tegra: pinmux tables and definitions for tegra30 Peter De Schrijver
2011-11-18 21:43 ` Olof Johansson
2011-11-18 21:51 ` Stephen Warren
2011-11-18 21:56 ` Olof Johansson
2011-11-17 16:19 ` [PATCH 09/10] arm/tegra: implement support " Peter De Schrijver
2011-11-17 19:50 ` Stephen Warren
2011-11-17 16:19 ` [PATCH 10/10] arm/tegra: add support for tegra30 based board cardhu Peter De Schrijver
2011-11-17 16:49 ` [PATCH v5 00/10] Add support for tegra30 and cardhu Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF1740D74F48@HQMAIL01.nvidia.com \
--to=swarren@nvidia.com \
--cc=ccross@android.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=pdeschrijver@nvidia.com \
--cc=rdunlap@xenotime.net \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®