From: Paul Cercueil <paul.cercueil@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Takahiro Kuwano <takahiro.kuwano@infineon.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, Tanmay Jagdale <tanmay@marvell.com>
Subject: Re: [PATCH 1/5] spi: spi-mem: Add support for panic mem writes
Date: Wed, 14 Oct 2026 10:54:56 +0200 [thread overview]
Message-ID: <74b2030cb64f8c25f95d51894d3296f180a34e01.camel@bootlin.com> (raw)
In-Reply-To: <629a4f32-2efe-4212-ac1f-f64c487caa63@sirena.org.uk>
Hi Mark,
Le mardi 13 octobre 2026 à 17:00 +0100, Mark Brown a écrit :
> On Tue, Oct 13, 2026 at 01:00:50PM +0200, Paul Cercueil wrote:
> > Le mardi 13 octobre 2026 à 11:42 +0100, Mark Brown a écrit :
>
> > > Do the other CPUs know they're panicing yet, and what state is the
> > > hardware in? I'm a bit nervous about assuming panic got things into a
> > > good state.
>
> > The other CPUs are stopped, yes. At that point there's no SMP, no
> > preemption, no
> > IRQs, no time accounting.
>
> My worry is what happens if we didn't actually manage to stop the other
> CPUs - in theory we've shut everything down, but I've been burned by the
> bug being IPIs breaking. Perhaps it's just not worth worrying about.
My understanding is that the panic handlers are written with the assumption that
everything is stopped, it's up to the calling code to ensure that it is true.
-Paul
next prev parent reply other threads:[~2026-10-14 8:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 8:11 [PATCH 0/5] spi: " Paul Cercueil
2026-10-05 8:11 ` [PATCH 1/5] spi: spi-mem: " Paul Cercueil
2026-10-05 8:24 ` sashiko-bot
2026-10-08 8:32 ` Mark Brown
2026-10-13 8:25 ` Paul Cercueil
2026-10-13 8:38 ` Miquel Raynal
2026-10-13 8:48 ` Paul Cercueil
2026-10-13 10:42 ` Mark Brown
2026-10-13 11:00 ` Paul Cercueil
2026-10-13 16:00 ` Mark Brown
2026-10-14 8:54 ` Paul Cercueil [this message]
2026-10-05 8:11 ` [PATCH 2/5] mtd: spi-nor: Add support for panic writes Paul Cercueil
2026-10-05 8:23 ` sashiko-bot
2026-10-05 8:11 ` [PATCH 3/5] spi: cadence-xspi: Add irq-less support Paul Cercueil
2026-10-05 8:24 ` sashiko-bot
2026-10-08 8:36 ` Mark Brown
2026-10-05 8:11 ` [PATCH 4/5] spi: cadence-xspi: Don't use infinite timeout in register poll Paul Cercueil
2026-10-05 8:21 ` sashiko-bot
2026-10-05 8:11 ` [PATCH 5/5] spi: cadence-xspi: Add support for panic writes Paul Cercueil
2026-10-05 8:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b2030cb64f8c25f95d51894d3296f180a34e01.camel@bootlin.com \
--to=paul.cercueil@bootlin.com \
--cc=broonie@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=takahiro.kuwano@infineon.com \
--cc=tanmay@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tony.luck@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®