mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Lukas Bulwahn <lbulwahn@redhat.com>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	"Michael J . Ruhl" <michael.j.ruhl@intel.com>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] dma-buf: really enable DMABUF_DEBUG by default on DEBUG kernels
Date: Wed, 17 Dec 2025 11:55:26 +0100	[thread overview]
Message-ID: <74b416f0-5bc4-40a3-93c2-ed5c5d2b56b0@amd.com> (raw)
In-Reply-To: <20251217102522.2790298-1-lukas.bulwahn@redhat.com>

On 12/17/25 11:25, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> 
> The intent of commit 646013f513f3 ("dma-buf: enable DMABUF_DEBUG by default
> on DEBUG kernels") is clear, but it mixes up the config option name. The
> config option for kernel debugging is named DEBUG_KERNEL, not DEBUG.
> 
> Fix up the DMABUF_DEBUG definition to use the intended name.
> 
> Fixes: 646013f513f3 ("dma-buf: enable DMABUF_DEBUG by default on DEBUG kernels")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>

Ah, yeah. I mixed up the C define vs the config option. Thanks for pointing that out.

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/dma-buf/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index fdd823e446cc..426c9ad3364f 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -55,7 +55,7 @@ config DMABUF_MOVE_NOTIFY
>  config DMABUF_DEBUG
>  	bool "DMA-BUF debug checks"
>  	depends on DMA_SHARED_BUFFER
> -	default y if DEBUG
> +	default y if DEBUG_KERNEL
>  	help
>  	  This option enables additional checks for DMA-BUF importers and
>  	  exporters. Specifically it validates that importers do not peek at the


      reply	other threads:[~2025-12-17 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 10:25 Lukas Bulwahn
2025-12-17 10:55 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74b416f0-5bc4-40a3-93c2-ed5c5d2b56b0@amd.com \
    --to=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lbulwahn@redhat.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lukas.bulwahn@redhat.com \
    --cc=michael.j.ruhl@intel.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®