* [PATCH] dma-buf: really enable DMABUF_DEBUG by default on DEBUG kernels
@ 2025-12-17 10:25 Lukas Bulwahn
2025-12-17 10:55 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2025-12-17 10:25 UTC (permalink / raw)
To: Sumit Semwal, Christian König, Michael J . Ruhl,
linux-media, dri-devel, linaro-mm-sig
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
The intent of commit 646013f513f3 ("dma-buf: enable DMABUF_DEBUG by default
on DEBUG kernels") is clear, but it mixes up the config option name. The
config option for kernel debugging is named DEBUG_KERNEL, not DEBUG.
Fix up the DMABUF_DEBUG definition to use the intended name.
Fixes: 646013f513f3 ("dma-buf: enable DMABUF_DEBUG by default on DEBUG kernels")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
drivers/dma-buf/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
index fdd823e446cc..426c9ad3364f 100644
--- a/drivers/dma-buf/Kconfig
+++ b/drivers/dma-buf/Kconfig
@@ -55,7 +55,7 @@ config DMABUF_MOVE_NOTIFY
config DMABUF_DEBUG
bool "DMA-BUF debug checks"
depends on DMA_SHARED_BUFFER
- default y if DEBUG
+ default y if DEBUG_KERNEL
help
This option enables additional checks for DMA-BUF importers and
exporters. Specifically it validates that importers do not peek at the
--
2.51.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] dma-buf: really enable DMABUF_DEBUG by default on DEBUG kernels
2025-12-17 10:25 [PATCH] dma-buf: really enable DMABUF_DEBUG by default on DEBUG kernels Lukas Bulwahn
@ 2025-12-17 10:55 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2025-12-17 10:55 UTC (permalink / raw)
To: Lukas Bulwahn, Sumit Semwal, Michael J . Ruhl, linux-media,
dri-devel, linaro-mm-sig
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
On 12/17/25 11:25, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> The intent of commit 646013f513f3 ("dma-buf: enable DMABUF_DEBUG by default
> on DEBUG kernels") is clear, but it mixes up the config option name. The
> config option for kernel debugging is named DEBUG_KERNEL, not DEBUG.
>
> Fix up the DMABUF_DEBUG definition to use the intended name.
>
> Fixes: 646013f513f3 ("dma-buf: enable DMABUF_DEBUG by default on DEBUG kernels")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
Ah, yeah. I mixed up the C define vs the config option. Thanks for pointing that out.
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/dma-buf/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index fdd823e446cc..426c9ad3364f 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -55,7 +55,7 @@ config DMABUF_MOVE_NOTIFY
> config DMABUF_DEBUG
> bool "DMA-BUF debug checks"
> depends on DMA_SHARED_BUFFER
> - default y if DEBUG
> + default y if DEBUG_KERNEL
> help
> This option enables additional checks for DMA-BUF importers and
> exporters. Specifically it validates that importers do not peek at the
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-17 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-17 10:25 [PATCH] dma-buf: really enable DMABUF_DEBUG by default on DEBUG kernels Lukas Bulwahn
2025-12-17 10:55 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®