From: Steven Price <steven.price@arm.com>
To: Karunika Choo <karunika.choo@arm.com>, dri-devel@lists.freedesktop.org
Cc: nd@arm.com, Boris Brezillon <boris.brezillon@collabora.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] drm/panthor: Add 64-bit register accessors
Date: Mon, 23 Dec 2024 17:06:01 +0000 [thread overview]
Message-ID: <74c43172-b55e-4c50-8a6d-061f616748d7@arm.com> (raw)
In-Reply-To: <20241219170521.64879-2-karunika.choo@arm.com>
On 19/12/2024 17:05, Karunika Choo wrote:
> This patch adds 64-bit register accessors to simplify register access in
> Panthor. It also adds 64-bit variants for read_poll_timeout and replaces
> all 64-bit and poll register accesses with these new functions.
>
> Signed-off-by: Karunika Choo <karunika.choo@arm.com>
(Minor NIT: This might be easier to review as two patches - one which
adds the new functions and a second which switching the code over to use
them).
[...]
> diff --git a/drivers/gpu/drm/panthor/panthor_regs.h b/drivers/gpu/drm/panthor/panthor_regs.h
> index b7b3b3add166..269c2c68dde2 100644
> --- a/drivers/gpu/drm/panthor/panthor_regs.h
> +++ b/drivers/gpu/drm/panthor/panthor_regs.h
> @@ -10,6 +10,9 @@
> #ifndef __PANTHOR_REGS_H__
> #define __PANTHOR_REGS_H__
>
> +#include <linux/iopoll.h>
> +
> +/* GX10 registers */
NIT: Please don't include unrelated changes like this comment.
Other than those minor issues, this looks like a nice improvement.
Steve
next prev parent reply other threads:[~2024-12-23 17:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 17:05 [RFC PATCH 0/4] drm/panthor: Add GPU specific initialization and feature detection Karunika Choo
2024-12-19 17:05 ` [RFC PATCH 1/4] drm/panthor: Add 64-bit register accessors Karunika Choo
2024-12-23 17:06 ` Steven Price [this message]
2024-12-19 17:05 ` [RFC PATCH 2/4] drm/panthor: Add parsed gpu properties Karunika Choo
2024-12-23 16:55 ` Steven Price
2024-12-19 17:05 ` [RFC PATCH 3/4] drm/panthor: Add gpu specific initialization framework Karunika Choo
2024-12-23 17:02 ` Steven Price
2024-12-19 17:05 ` [RFC PATCH 4/4] drm/panthor: Use GPU_COMMAND.FLUSH_CACHES for cache maintenance Karunika Choo
2024-12-23 17:05 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c43172-b55e-4c50-8a6d-061f616748d7@arm.com \
--to=steven.price@arm.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karunika.choo@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nd@arm.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®