mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jinguojun <kid.jin@hisilicon.com>
To: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <ulf.hansson@linaro.org>,
	<adrian.hunter@intel.com>, <jh80.chung@samsung.com>,
	<wsa+renesas@sang-engineering.com>, <arnd@arndb.de>,
	<rmk+kernel@arm.linux.org.uk>, <shawn.lin@rock-chips.com>
Cc: <guodong.xu@linaro.org>, <kongfei@hisilicon.com>,
	<suzhuangluan@hisilicon.com>
Subject: Re: [PATCH V4]mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey
Date: Mon, 8 Aug 2016 15:10:31 +0800	[thread overview]
Message-ID: <74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com> (raw)
In-Reply-To: <1470276973-41683-1-git-send-email-kid.jin@hisilicon.com>

Hi,maintainers

Pls help to review code,this is the newest patch after your advise

Thx
On 2016/8/4 10:16, Jin Guojun wrote:
> mmc: dw_mmc-k3: Hisilicon Hikey have no tuning function in 
> dw_mmc-k3.c,so we must do the tuning function stub when we init UHS card.
> 
> V1:add .prepare_command in dw_mmc.c
> V2:delete .prepare_command, add err = 0 in dw_mci_execute_tuning
> V3:delete err = 0 in dw_mci_execute_tuning,add .execute_tuning in 
> dw_mmc-k3.c
> V4:add "linux-mmc@vger.kernel.org", patch version, Changelog, etc..
> 
> Signed-off-by: Jin Guojun <kid.jin@hisilicon.com>
> ---
>  drivers/mmc/host/dw_mmc-k3.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 8e9d886..6247894 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -131,11 +131,17 @@ static void dw_mci_hi6220_set_ios(struct dw_mci *host, struct mmc_ios *ios)
>  	host->bus_hz = clk_get_rate(host->biu_clk);
>  }
>  
> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
> +{
> +	return 0;
> +}
> +
>  static const struct dw_mci_drv_data hi6220_data = {
>  	.caps			= dw_mci_hi6220_caps,
>  	.switch_voltage		= dw_mci_hi6220_switch_voltage,
>  	.set_ios		= dw_mci_hi6220_set_ios,
>  	.parse_dt		= dw_mci_hi6220_parse_dt,
> +	.execute_tuning		= dw_mci_hi6220_execute_tuning,
>  };
>  
>  static const struct of_device_id dw_mci_k3_match[] = {
> 

  reply	other threads:[~2016-08-08  7:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04  2:16 Jin Guojun
2016-08-08  7:10 ` Jinguojun [this message]
2016-08-08  9:10   ` Shawn Lin
2016-08-08 10:46     ` Jaehoon Chung
2016-08-17  6:11       ` Jinguojun
2016-08-17  7:20         ` Jaehoon Chung
2016-08-23  9:00           ` Jinguojun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com \
    --to=kid.jin@hisilicon.com \
    --cc=adrian.hunter@intel.com \
    --cc=arnd@arndb.de \
    --cc=guodong.xu@linaro.org \
    --cc=jh80.chung@samsung.com \
    --cc=kongfei@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=shawn.lin@rock-chips.com \
    --cc=suzhuangluan@hisilicon.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®