mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "pHilipp Zabel" <philipp.zabel@gmail.com>
To: "Russell King" <rmk+lkml@arm.linux.org.uk>
Cc: "Harvey Harrison" <harvey.harrison@gmail.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Randy Dunlap" <randy.dunlap@oracle.com>
Subject: Re: [PATCH] mfd: kconfig exposing unbuildable driver
Date: Wed, 23 Apr 2008 22:02:04 +0200	[thread overview]
Message-ID: <74d0deb30804231302v1526d018v8d39cb17d231f25f@mail.gmail.com> (raw)
In-Reply-To: <20080422203334.GA9809@flint.arm.linux.org.uk>

On Tue, Apr 22, 2008 at 10:33 PM, Russell King
<rmk+lkml@arm.linux.org.uk> wrote:
> That was my initial approach as well, which got shot down by Andrew
>  Morton and others as being unacceptable.

'Shot down' is a bit harsh. I just argued that technically the driver
does not depend on ARM (and neither does the ASIC, most probably).
On the other hand, AFAIK it is proprietary HTC silicon only found in a
handful of their devices, all of which are PXA2xx based.

>  On Tue, Apr 22, 2008 at 01:25:50PM -0700, Harvey Harrison wrote:
>  > Limit this driver to ARCH_PXA, noticed by breakage on allyesconfig
>  > builds on 32-bit x86.
>  >
>  > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>  > ---
>  > Linus, please apply and Russell can fix it up however he likes later
>  > in the week.  Many people are hitting this.
>  >
>  >  drivers/mfd/Kconfig |    1 +
>  >  1 files changed, 1 insertions(+), 0 deletions(-)
>  >
>  > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>  > index 2566479..bd29c61 100644
>  > --- a/drivers/mfd/Kconfig
>  > +++ b/drivers/mfd/Kconfig
>  > @@ -32,6 +32,7 @@ config HTC_EGPIO
>  >
>  >  config HTC_PASIC3
>  >       tristate "HTC PASIC3 LED/DS1WM chip support"
>  > +     depends on ARCH_PXA
>  >       help
>  >         This core driver provides register access for the LED/DS1WM
>  >         chips labeled "AIC2" and "AIC3", found on HTC Blueangel and
>  > --
>  > 1.5.5.144.g3e42
>  >
>  >
>  >
>
>  --
>  Russell King
>   Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
>   maintainer of:
>
>
> --
>  To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>  the body of a message to majordomo@vger.kernel.org
>  More majordomo info at  http://vger.kernel.org/majordomo-info.html
>  Please read the FAQ at  http://www.tux.org/lkml/
>

regards
Philipp

      parent reply	other threads:[~2008-04-23 20:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 20:25 Harvey Harrison
2008-04-22 20:33 ` Russell King
2008-04-22 20:38   ` Randy.Dunlap
2008-04-22 20:45     ` Russell King
2008-04-22 20:47       ` Randy.Dunlap
2008-04-22 21:01         ` Russell King
2008-04-22 21:06           ` Randy Dunlap
2008-04-23  6:02           ` Andrew Morton
2008-04-22 21:05   ` Linus Torvalds
2008-04-22 21:36     ` Russell King
2008-04-22 21:47       ` Linus Torvalds
2008-04-23 20:14     ` pHilipp Zabel
2008-04-23 20:02   ` pHilipp Zabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74d0deb30804231302v1526d018v8d39cb17d231f25f@mail.gmail.com \
    --to=philipp.zabel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®