mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] mfd: kconfig exposing unbuildable driver
Date: Tue, 22 Apr 2008 14:05:29 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0804221359360.2779@woody.linux-foundation.org> (raw)
In-Reply-To: <20080422203334.GA9809@flint.arm.linux.org.uk>



On Tue, 22 Apr 2008, Russell King wrote:
>
> That was my initial approach as well, which got shot down by Andrew
> Morton and others as being unacceptable.

Hmm. While I in general support the notion of trying to compile drivers on 
as wide a variety as hardware as possible, if that HTC_PASIC3 thing really 
is a PXA-only piece of hardware, I don't really see the point of not 
making the config file accurately represent that.

That said, as far as I can tell, the compile failure is because of this 
line:

	#include <asm/arch/pxa-regs.h>

and I cannot for the life of me see _why_ it tries to include that header 
file. It seems to compile fine on x96-64 if you just remove that include, 
and while I still think it should depend on ARCH_PXA just because it makes 
no sense _not_ to, I do wonder why that include is there in the first 
place.

Hmm?

		Linus

  parent reply	other threads:[~2008-04-22 21:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 20:25 Harvey Harrison
2008-04-22 20:33 ` Russell King
2008-04-22 20:38   ` Randy.Dunlap
2008-04-22 20:45     ` Russell King
2008-04-22 20:47       ` Randy.Dunlap
2008-04-22 21:01         ` Russell King
2008-04-22 21:06           ` Randy Dunlap
2008-04-23  6:02           ` Andrew Morton
2008-04-22 21:05   ` Linus Torvalds [this message]
2008-04-22 21:36     ` Russell King
2008-04-22 21:47       ` Linus Torvalds
2008-04-23 20:14     ` pHilipp Zabel
2008-04-23 20:02   ` pHilipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0804221359360.2779@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®