mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Whitcroft <apw@canonical.com>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Gustavo Silva <gustavoars@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] checkpatch: Add a couple new alloc functions to alloc with multiplies check
Date: Wed, 13 Sep 2023 16:00:32 -0700	[thread overview]
Message-ID: <7502c1de6c25668699db7ca557f4cd61f2f1eab6.camel@perches.com> (raw)
In-Reply-To: <8cf58a8a-5410-4d3f-eb1a-e5bb6ce36023@embeddedor.com>

On Wed, 2023-09-13 at 16:41 -0600, Gustavo A. R. Silva wrote:
> 
> On 9/13/23 16:34, Joe Perches wrote:
> > On Wed, 2023-09-13 at 16:32 -0600, Gustavo A. R. Silva wrote:
> > > 
> > > On 9/13/23 16:25, Joe Perches wrote:
> > > > On Wed, 2023-09-13 at 16:14 -0600, Gustavo A. R. Silva wrote:
> > > > > 
> > > > > On 9/13/23 14:37, Joe Perches wrote:
> > > > > > vmalloc() and vzalloc() functions have now 2-factor multiplication
> > > > > > argument forms vmalloc_array() and vcalloc(), correspondingly.
> > > > > > 
> > > > > > Add alloc-with-multiplies checks for these new functions.
> > > > > > 
> > > > > > Simplify the original codes repeated else to use a hash.
> > > > > > 
> > > > > > Link: https://github.com/KSPP/linux/issues/342
> > > > > > 
> > > > > > Original-patch-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > > > > 
> > > > > Why don't you wait for a response or a v2 from the original
> > > > > submitter?
> > > > 
> > > > Because there really is no need to wait.
> > > 
> > > By the way, did you test it?
> > 
> > Yes, against arch/s390/include/asm/idals.h
> 
> I don't see any instances of vmalloc() or vzalloc() in that file.

<snort>  Cute.

Missing a ? in the original search '\s*,?'
or just its removal...

Likely the removal would be better.

thanks, cheers, Joe

  reply	other threads:[~2023-09-13 23:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 20:37 [PATCH 0/2] checkpatch: refactor and add new alloc w/ multiply tests Joe Perches
2023-09-13 20:37 ` [PATCH 1/2] checkpatch: Simplify creating search strings Joe Perches
2023-09-13 20:37 ` [PATCH 2/2] checkpatch: Add a couple new alloc functions to alloc with multiplies check Joe Perches
2023-09-13 22:14   ` Gustavo A. R. Silva
2023-09-13 22:25     ` Joe Perches
2023-09-13 22:32       ` Gustavo A. R. Silva
2023-09-13 22:34         ` Joe Perches
2023-09-13 22:41           ` Gustavo A. R. Silva
2023-09-13 23:00             ` Joe Perches [this message]
2023-09-14  1:41 ` [PATCH V2 " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7502c1de6c25668699db7ca557f4cd61f2f1eab6.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=gustavo@embeddedor.com \
    --cc=gustavoars@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®