Re: [PATCH v2] ksmbd: add kcov remote coverage support via ksmbd_conn

[Yunseong Kim <ysk@kzalloc.com>]

Hi Stefan,

On 8/6/25 10:57 오후, Stefan Metzmacher wrote:
> Hi Yunseong,
> 
>> diff --git a/fs/smb/server/connection.c b/fs/smb/server/connection.c
>> index 3f04a2977ba8..21352f37384f 100644
>> --- a/fs/smb/server/connection.c
>> +++ b/fs/smb/server/connection.c
>> @@ -93,6 +93,9 @@ struct ksmbd_conn *ksmbd_conn_alloc(void)
>>       down_write(&conn_list_lock);
>>       list_add(&conn->conns_list, &conn_list);
>>       up_write(&conn_list_lock);
>> +
>> +    ksmbd_conn_set_kcov_handle(conn, kcov_common_handle());
>> +
>>       return conn;
>>   }
> 
> ...
> 
>> +
>> +static inline void ksmbd_conn_set_kcov_handle(struct ksmbd_conn *conn,
>> +                       const u64 kcov_handle)
>> +{
>> +#ifdef CONFIG_KCOV
>> +    conn->kcov_handle = kcov_common_handle();
>> +#endif
>> +}
> 
> The caller passes kcov_common_handle() as argument, which is not used
> but kcov_common_handle() is called again...
> 
> metze

You're right — this is definitely wrong. I'll fix it and send an updated
version. Thanks!


Best regards,
Yunseong Kim