From: Stefan Metzmacher <metze@samba.org>
To: Yunseong Kim <ysk@kzalloc.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>
Cc: Paulo Alcantara <pc@manguebit.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Tom Talpey <tom@talpey.com>,
linux-cifs@vger.kernel.org, syzkaller@googlegroups.com,
linux-kernel@vger.kernel.org, notselwyn@pwning.tech
Subject: Re: [PATCH v2] ksmbd: add kcov remote coverage support via ksmbd_conn
Date: Wed, 6 Aug 2025 15:57:55 +0200 [thread overview]
Message-ID: <91f09266-b81e-4e28-95c3-4272096a0fca@samba.org> (raw)
In-Reply-To: <20250806135224.116724-2-ysk@kzalloc.com>
Hi Yunseong,
> diff --git a/fs/smb/server/connection.c b/fs/smb/server/connection.c
> index 3f04a2977ba8..21352f37384f 100644
> --- a/fs/smb/server/connection.c
> +++ b/fs/smb/server/connection.c
> @@ -93,6 +93,9 @@ struct ksmbd_conn *ksmbd_conn_alloc(void)
> down_write(&conn_list_lock);
> list_add(&conn->conns_list, &conn_list);
> up_write(&conn_list_lock);
> +
> + ksmbd_conn_set_kcov_handle(conn, kcov_common_handle());
> +
> return conn;
> }
...
> +
> +static inline void ksmbd_conn_set_kcov_handle(struct ksmbd_conn *conn,
> + const u64 kcov_handle)
> +{
> +#ifdef CONFIG_KCOV
> + conn->kcov_handle = kcov_common_handle();
> +#endif
> +}
The caller passes kcov_common_handle() as argument, which is not used
but kcov_common_handle() is called again...
metze
next prev parent reply other threads:[~2025-08-06 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 13:52 Yunseong Kim
2025-08-06 13:57 ` Stefan Metzmacher [this message]
2025-08-06 14:12 ` Yunseong Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f09266-b81e-4e28-95c3-4272096a0fca@samba.org \
--to=metze@samba.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notselwyn@pwning.tech \
--cc=pc@manguebit.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=syzkaller@googlegroups.com \
--cc=tom@talpey.com \
--cc=ysk@kzalloc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®