From: Neha Malcom Francis <n-francis@ti.com>
To: Romain Naour <romain.naour@smile.fr>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <conor+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
<kristo@kernel.org>, <vigneshr@ti.com>, <nm@ti.com>
Subject: Re: [PATCH v2 1/2] arm64: dts: ti: k3-am69-sk: fix PMIC interrupt number
Date: Wed, 14 Feb 2024 15:03:18 +0530 [thread overview]
Message-ID: <75241296-c698-4983-9dcd-9f59c31cb286@ti.com> (raw)
In-Reply-To: <20240209171146.307465-1-romain.naour@smile.fr>
Hi Romain
On 09/02/24 22:41, Romain Naour wrote:
> The tps659413 node set WKUP_GPIO0_83 (AA37) pin as input to be used as
> PMIC interrupt but uses 39 (WKUP_GPIO0_39) as "interrupts" property.
>
> Replace 39 by 83 after checking in the board schematic [1].
>
> [1] https://www.ti.com/tool/SK-AM69
>
> Fixes: 865a1593bf99 ("arm64: dts: ti: k3-am69-sk: Add support for TPS6594 PMIC")
> Cc: Neha Malcom Francis <n-francis@ti.com>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> index 8da591579868..95c9d3da59d3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> @@ -646,7 +646,7 @@ tps659413: pmic@48 {
> pinctrl-names = "default";
> pinctrl-0 = <&pmic_irq_pins_default>;
> interrupt-parent = <&wkup_gpio0>;
> - interrupts = <39 IRQ_TYPE_EDGE_FALLING>;
> + interrupts = <83 IRQ_TYPE_EDGE_FALLING>;
> gpio-controller;
> #gpio-cells = <2>;
> ti,primary-pmic;
Thanks for catching this!
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
next prev parent reply other threads:[~2024-02-14 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 17:11 Romain Naour
2024-02-09 17:11 ` [PATCH v2 2/2] arm64: dts: ti: k3-j721e-sk: " Romain Naour
2024-02-14 9:33 ` Neha Malcom Francis
2024-02-14 9:33 ` Neha Malcom Francis [this message]
2024-02-15 9:26 ` [PATCH v2 1/2] arm64: dts: ti: k3-am69-sk: " Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75241296-c698-4983-9dcd-9f59c31cb286@ti.com \
--to=n-francis@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=romain.naour@smile.fr \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®