mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neha Malcom Francis <n-francis@ti.com>
To: Romain Naour <romain.naour@smile.fr>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <conor+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
	<kristo@kernel.org>, <vigneshr@ti.com>, <nm@ti.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-sk: fix PMIC interrupt number
Date: Wed, 14 Feb 2024 15:03:36 +0530	[thread overview]
Message-ID: <a8ed43ca-d2fb-4dce-ba9f-9c52e5a05b1a@ti.com> (raw)
In-Reply-To: <20240209171146.307465-2-romain.naour@smile.fr>

On 09/02/24 22:41, Romain Naour wrote:
> The tps659413 and tps659411 nodes set WKUP_GPIO0_7 (G28) pin as input
> to be used as PMIC interrupt but uses 9 (WKUP_GPIO0_9) as
> "interrupts" property.
> 
> Replace 9 by 7 for both tps659413 and tps659411 after checking in the
> board schematic [1].
> 
> [1] https://www.ti.com/tool/SK-TDA4VM
> 
> Fixes: b808cef0be46 ("arm64: dts: ti: k3-j721e-sk: Add TPS6594 family PMICs")
> Cc: Neha Malcom Francis <n-francis@ti.com>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
> v2: update tps659411 interrupts parameter too.
> ---
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 188dfe291a32..658764f7d544 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -574,7 +574,7 @@ tps659413: pmic@48 {
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&pmic_irq_pins_default>;
>   		interrupt-parent = <&wkup_gpio0>;
> -		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>   		gpio-controller;
>   		#gpio-cells = <2>;
>   		ti,primary-pmic;
> @@ -651,7 +651,7 @@ tps659411: pmic@4c {
>   		reg = <0x4c>;
>   		system-power-controller;
>   		interrupt-parent = <&wkup_gpio0>;
> -		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>   		gpio-controller;
>   		#gpio-cells = <2>;
>   		buck1234-supply = <&vsys_3v3>;


Reviewed-by: Neha Malcom Francis <n-francis@ti.com>

-- 
Thanking You
Neha Malcom Francis

  reply	other threads:[~2024-02-14  9:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 17:11 [PATCH v2 1/2] arm64: dts: ti: k3-am69-sk: " Romain Naour
2024-02-09 17:11 ` [PATCH v2 2/2] arm64: dts: ti: k3-j721e-sk: " Romain Naour
2024-02-14  9:33   ` Neha Malcom Francis [this message]
2024-02-14  9:33 ` [PATCH v2 1/2] arm64: dts: ti: k3-am69-sk: " Neha Malcom Francis
2024-02-15  9:26 ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8ed43ca-d2fb-4dce-ba9f-9c52e5a05b1a@ti.com \
    --to=n-francis@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=romain.naour@smile.fr \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®