mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jing Liu <jing2.liu@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/5] KVM: cpuid: extract do_cpuid_7_mask and support multiple subleafs
Date: Wed, 10 Jul 2019 15:32:34 +0800	[thread overview]
Message-ID: <752c2473-04d9-8420-a78f-fa677f806aca@linux.intel.com> (raw)
In-Reply-To: <d3454d11-97fb-42f2-0a0c-add0456b076c@redhat.com>



On 7/10/2019 2:30 PM, Paolo Bonzini wrote:
> On 08/07/19 09:07, Jing Liu wrote:
>>>
>> And when adding subleaf 1, plan to add codes,
>>
>> case 1:
>>      entry->eax |= kvm_cpuid_7_1_eax_x86_features;
>>      entry->ebx = entry->ecx = entry->edx =0;
>>      break;
>>
>> What do you think?
> 
> This should be "&=", not "|=".  Otherwise yes, that's the idea.
> 

Yes! So let me send out the BFloat16 patch based on your patch set now
or you have merge plan soon?

Thanks,
Jing

> Paolo
> 

  reply	other threads:[~2019-07-10  7:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 14:07 [PATCH 0/5] KVM: cpuid: cleanups, simplify multi-index CPUID leaves Paolo Bonzini
2019-07-04 14:07 ` [PATCH 1/5] KVM: cpuid: do_cpuid_ent works on a whole CPUID function Paolo Bonzini
2019-07-08  7:05   ` Jing Liu
2019-07-04 14:07 ` [PATCH 2/5] KVM: cpuid: extract do_cpuid_7_mask and support multiple subleafs Paolo Bonzini
2019-07-08  7:07   ` Jing Liu
2019-07-10  6:30     ` Paolo Bonzini
2019-07-10  7:32       ` Jing Liu [this message]
2019-07-10  7:48         ` Paolo Bonzini
2019-07-04 14:07 ` [PATCH 3/5] KVM: cpuid: set struct kvm_cpuid_entry2 flags in do_cpuid_1_ent Paolo Bonzini
2019-07-04 14:07 ` [PATCH 4/5] KVM: cpuid: rename do_cpuid_1_ent Paolo Bonzini
2019-07-04 14:07 ` [PATCH 5/5] KVM: cpuid: remove has_leaf_count from struct kvm_cpuid_param Paolo Bonzini
2019-07-08  7:09   ` Jing Liu
2019-07-10  6:34     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=752c2473-04d9-8420-a78f-fa677f806aca@linux.intel.com \
    --to=jing2.liu@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome