* [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2
@ 2023-10-12 4:50 Lukas Bulwahn
2023-10-12 5:15 ` Vasant Hegde
2023-10-12 16:10 ` Kees Cook
0 siblings, 2 replies; 5+ messages in thread
From: Lukas Bulwahn @ 2023-10-12 4:50 UTC (permalink / raw)
To: iommu, Joerg Roedel, Suravee Suthikulpanit, Vasant Hegde
Cc: Kees Cook, Gustavo A . R . Silva, linux-hardening,
kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the
config AMD_IOMMU_V2.
Remove the reference to this config in the x86 architecture-specific
hardening config fragment as well.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Joerg, please pick this patch on top of the commit above. Thanks.
arch/x86/configs/hardening.config | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/configs/hardening.config b/arch/x86/configs/hardening.config
index 19bb0c7a7669..7b497f3b7bc3 100644
--- a/arch/x86/configs/hardening.config
+++ b/arch/x86/configs/hardening.config
@@ -9,7 +9,6 @@ CONFIG_INTEL_IOMMU=y
CONFIG_INTEL_IOMMU_DEFAULT_ON=y
CONFIG_INTEL_IOMMU_SVM=y
CONFIG_AMD_IOMMU=y
-CONFIG_AMD_IOMMU_V2=y
# Enable CET Shadow Stack for userspace.
CONFIG_X86_USER_SHADOW_STACK=y
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2
2023-10-12 4:50 [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2 Lukas Bulwahn
@ 2023-10-12 5:15 ` Vasant Hegde
2023-10-12 6:35 ` Dan Carpenter
2023-10-12 16:10 ` Kees Cook
1 sibling, 1 reply; 5+ messages in thread
From: Vasant Hegde @ 2023-10-12 5:15 UTC (permalink / raw)
To: Lukas Bulwahn, iommu, Joerg Roedel, Suravee Suthikulpanit
Cc: Kees Cook, Gustavo A . R . Silva, linux-hardening,
kernel-janitors, linux-kernel
On 10/12/2023 10:20 AM, Lukas Bulwahn wrote:
> Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the
> config AMD_IOMMU_V2.
>
> Remove the reference to this config in the x86 architecture-specific
> hardening config fragment as well.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Joerg, please pick this patch on top of the commit above. Thanks.
>
> arch/x86/configs/hardening.config | 1 -
Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I
missing something?
-Vasant
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/configs/hardening.config b/arch/x86/configs/hardening.config
> index 19bb0c7a7669..7b497f3b7bc3 100644
> --- a/arch/x86/configs/hardening.config
> +++ b/arch/x86/configs/hardening.config
> @@ -9,7 +9,6 @@ CONFIG_INTEL_IOMMU=y
> CONFIG_INTEL_IOMMU_DEFAULT_ON=y
> CONFIG_INTEL_IOMMU_SVM=y
> CONFIG_AMD_IOMMU=y
> -CONFIG_AMD_IOMMU_V2=y
>
> # Enable CET Shadow Stack for userspace.
> CONFIG_X86_USER_SHADOW_STACK=y
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2
2023-10-12 5:15 ` Vasant Hegde
@ 2023-10-12 6:35 ` Dan Carpenter
2023-10-12 6:57 ` Vasant Hegde
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2023-10-12 6:35 UTC (permalink / raw)
To: Vasant Hegde
Cc: Lukas Bulwahn, iommu, Joerg Roedel, Suravee Suthikulpanit,
Kees Cook, Gustavo A . R . Silva, linux-hardening,
kernel-janitors, linux-kernel
On Thu, Oct 12, 2023 at 10:45:03AM +0530, Vasant Hegde wrote:
>
>
> On 10/12/2023 10:20 AM, Lukas Bulwahn wrote:
> > Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the
> > config AMD_IOMMU_V2.
> >
> > Remove the reference to this config in the x86 architecture-specific
> > hardening config fragment as well.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > Joerg, please pick this patch on top of the commit above. Thanks.
> >
> > arch/x86/configs/hardening.config | 1 -
>
> Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I
> missing something?
>
It was added on Aug 24 in linux-next.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2
2023-10-12 6:35 ` Dan Carpenter
@ 2023-10-12 6:57 ` Vasant Hegde
0 siblings, 0 replies; 5+ messages in thread
From: Vasant Hegde @ 2023-10-12 6:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lukas Bulwahn, iommu, Joerg Roedel, Suravee Suthikulpanit,
Kees Cook, Gustavo A . R . Silva, linux-hardening,
kernel-janitors, linux-kernel
On 10/12/2023 12:05 PM, Dan Carpenter wrote:
> On Thu, Oct 12, 2023 at 10:45:03AM +0530, Vasant Hegde wrote:
>>
>>
>> On 10/12/2023 10:20 AM, Lukas Bulwahn wrote:
>>> Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the
>>> config AMD_IOMMU_V2.
>>>
>>> Remove the reference to this config in the x86 architecture-specific
>>> hardening config fragment as well.
>>>
>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>>> ---
>>> Joerg, please pick this patch on top of the commit above. Thanks.
>>>
>>> arch/x86/configs/hardening.config | 1 -
>>
>> Thanks for the fix Lukas. But I don't see this file in upstream linux tree. Am I
>> missing something?
>>
>
> It was added on Aug 24 in linux-next.
Thanks Dan. I can see the patch in linux-next.
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2
2023-10-12 4:50 [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2 Lukas Bulwahn
2023-10-12 5:15 ` Vasant Hegde
@ 2023-10-12 16:10 ` Kees Cook
1 sibling, 0 replies; 5+ messages in thread
From: Kees Cook @ 2023-10-12 16:10 UTC (permalink / raw)
To: iommu, Joerg Roedel, Suravee Suthikulpanit, Vasant Hegde, Lukas Bulwahn
Cc: Kees Cook, Gustavo A . R . Silva, linux-hardening,
kernel-janitors, linux-kernel
On Thu, 12 Oct 2023 06:50:40 +0200, Lukas Bulwahn wrote:
> Commit 5a0b11a180a9 ("iommu/amd: Remove iommu_v2 module") removes the
> config AMD_IOMMU_V2.
>
> Remove the reference to this config in the x86 architecture-specific
> hardening config fragment as well.
>
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] hardening: x86: drop reference to removed config AMD_IOMMU_V2
https://git.kernel.org/kees/c/faed498d0db7
Take care,
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-12 16:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 4:50 [PATCH] hardening: x86: drop reference to removed config AMD_IOMMU_V2 Lukas Bulwahn
2023-10-12 5:15 ` Vasant Hegde
2023-10-12 6:35 ` Dan Carpenter
2023-10-12 6:57 ` Vasant Hegde
2023-10-12 16:10 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®