mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
	cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gfs2: Fix wrong error handling in init_gfs2_fs()
Date: Tue, 28 Nov 2017 08:41:36 -0500 (EST)	[thread overview]
Message-ID: <754398122.35111640.1511876496295.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1511416659-4595-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

----- Original Message -----
| init_gfs2_fs() is calling e.g. calling unregister_shrinker() without
| register_shrinker() when an error occurred during initialization.
| Rename goto labels and call appropriate undo function.
| 
| Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
| ---
|  fs/gfs2/main.c | 90
|  ++++++++++++++++++++++++++++------------------------------
|  1 file changed, 44 insertions(+), 46 deletions(-)
Hi,

ACK.

Thanks; this is a nice cleanup.

This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=8b0d7f56b97b95a442b6785027a0f80ad1ea54af

Regards,

Bob Peterson
Red Hat File Systems

      reply	other threads:[~2017-11-28 13:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23  5:57 Tetsuo Handa
2017-11-28 13:41 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=754398122.35111640.1511876496295.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome