Re: [PATCH] misc: fastrpc: Allocate message buffer from remote heap for sensors PD

Re: [PATCH] misc: fastrpc: Allocate message buffer from remote heap for sensors PD

[Piyush Raj Chouhan]

Hi Robin,

   I am really sorry about the attribution mix-up. Using Suggested-by 
was an honest mistake on my end while preparing the submission, and I 
apologize for that.

   I've fixed this in v2: you are set as the patch author with your 
original Signed-off-by retained, followed by my sign-off for testing and 
submitting. (Because git send-email dispatches through my server, the 
outer email envelope will show my address, but the mbox body preserves 
From: Robin Snyders <robin@snyders.xyz> so git am records you as author).

   Thanks for pointing this out and for authoring the fix!

   Best regards,
   Piyush

On 03/10/26 14:01, robin wrote:
> Robin Snyders <robin@snyders.xyz>

[PATCH] misc: fastrpc: Allocate message buffer from remote heap for sensors PD

[Piyush Raj Chouhan]

The sensors protection domain reaches the message buffer directly rather
than through its context bank, so it requires an allocation from the
reserved remote heap memory pool. Using a context-bank buffer allocation
leaves the DSP addressing memory that is not mapped in its address space,
triggering an SMMU context fault (e.g. 0x1fffff000) or bus stall.

Ensure the remote heap is used for SENSORS_PD invocations even when
a stream ID (sid) is present.

Suggested-by: Robin Snyders <robin@snyders.xyz>
Signed-off-by: Piyush Raj Chouhan <pc1598@mainlining.org>
---
 drivers/misc/fastrpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index d4fac2caca86..8f39f4bed20e 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1099,7 +1099,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc_invoke_ctx *ctx)
 
 	ctx->msg_sz = pkt_size;
 
-	if (ctx->fl->sctx->sid)
+	if (ctx->fl->sctx->sid && ctx->fl->pd != SENSORS_PD)
 		err = fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
 	else
 		err = fastrpc_remote_heap_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
-- 
2.55.0