From: Joe Perches <joe@perches.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: vt6655: Rename pbyEtherAddr to mac_addr
Date: Mon, 04 Jul 2022 12:05:33 -0700 [thread overview]
Message-ID: <757323ceeb72b2d80acfae9ae4f384c27d731bbe.camel@perches.com> (raw)
In-Reply-To: <fcc66446a04c1ecb3c2b66cdd47e932c231b1b9d.1656835310.git.philipp.g.hortmann@gmail.com>
On Mon, 2022-07-04 at 20:20 +0200, Philipp Hortmann wrote:
> Fix name of a variable in two macros that use CamelCase which is not
> accepted by checkpatch.pl
These might be nicer as functions with for loops
> diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
maybe something like:
static inline void MACvWriteBSSIDAddress(void __iomem *iobase, u8 *addr)
{
int i;
for (i = 0; i < ETH_ALEN; i++)
iowrite8(*addr++, iobase + MAC_REG_BSSID0 + i);
}
static inline void MACvReadEtherAddress(void __iomem *iobase, u8 *addr)
{
int i;
iowrite8(1, iobase + MAC_REG_PAGE1SEL);
for (i = 0; i < ETH_ALEN; i++)
*addr++ = ioread8(iobase + MAC_REG_PAR0 + i);
iowrite8(0, iobase + MAC_REG_PAGE1SEL);
}
next prev parent reply other threads:[~2022-07-04 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 18:20 [PATCH 0/6] staging: vt6655: Convert two macros to static functions Philipp Hortmann
2022-07-04 18:20 ` [PATCH 1/6] staging: vt6655: Rename pbyEtherAddr to mac_addr Philipp Hortmann
2022-07-04 19:05 ` Joe Perches [this message]
2022-07-04 18:20 ` [PATCH 2/6] staging: vt6655: Rename MACvWriteBSSIDAddress Philipp Hortmann
2022-07-04 18:20 ` [PATCH 3/6] staging: vt6655: Rename MACvReadEtherAddress Philipp Hortmann
2022-07-04 18:20 ` [PATCH 4/6] staging: vt6655: Move two macros to file where those are used Philipp Hortmann
2022-07-04 18:20 ` [PATCH 5/6] staging: vt6655: Convert macro vt6655_mac_write_bssid_addr to function Philipp Hortmann
2022-07-04 18:21 ` [PATCH 6/6] staging: vt6655: Convert macro vt6655_mac_read_ether_addr " Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757323ceeb72b2d80acfae9ae4f384c27d731bbe.camel@perches.com \
--to=joe@perches.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome