From: Mike Galbraith <efault@gmx.de>
To: Peter Zijlstra <peterz@infradead.org>,
mingo@kernel.org, vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
corbet@lwn.net, qyousef@layalina.io, chris.hyser@oracle.com,
patrick.bellasi@matbug.net, pjt@google.com, pavel@ucw.cz,
qperret@google.com, tim.c.chen@linux.intel.com,
joshdon@google.com, timj@gnu.org, kprateek.nayak@amd.com,
yu.c.chen@intel.com, youssefesmat@chromium.org,
joel@joelfernandes.org
Subject: Re: [PATCH 15/17] [RFC] sched/eevdf: Sleeper bonus
Date: Wed, 29 Mar 2023 11:10:28 +0200 [thread overview]
Message-ID: <7577c8e361ee311d019f40b8921099f3e9aa2d23.camel@gmx.de> (raw)
In-Reply-To: <20230328110354.641979416@infradead.org>
On Tue, 2023-03-28 at 11:26 +0200, Peter Zijlstra wrote:
> Add a sleeper bonus hack, but keep it default disabled. This should
> allow easy testing if regressions are due to this.
>
> Specifically; this 'restores' performance for things like starve and
> stress-futex, stress-nanosleep that rely on sleeper bonus to compete
> against an always running parent (the fair 67%/33% split vs the
> 50%/50% bonus thing).
>
> OTOH this completely destroys latency and hackbench (as in 5x worse).
I profiled that again, but numbers were still.. not so lovely.
Point of this post is the sleeper/hog split business anyway. I've been
running your patches on my desktop box and cute as button little rpi4b
since they appeared, and poking at them looking for any desktop deltas
and have noticed jack diddly spit.
A lot of benchmarks will notice both distribution and ctx deltas, but
humans.. the numbers I've seen so far say that's highly unlikely.
A couple perf sched lat summaries below for insomniacs.
Load is chrome playing BigBuckBunny (for the zillionth time), which on
this box as I set resolution/size wants ~35% of the box vs 8ms run 1ms
sleep massive_intr, 1 thread per CPU (profiles at ~91%), as a hog-ish
but not absurdly so competitor.
perf.data.stable.full sort=max - top 10 summary
-----------------------------------------------------------------------------------------------------------
Task | Runtime ms | Switches | Avg delay ms | Max delay ms | Sum delay ms |
-----------------------------------------------------------------------------------------------------------
chrome:(7) | 6274.683 ms | 63604 | avg: 0.172 ms | max: 41.796 ms | sum:10930.150 ms |
massive_intr:(8) |1673597.295 ms | 762617 | avg: 0.709 ms | max: 40.383 ms | sum:540374.853 ms |
X:2476 | 86498.438 ms | 129657 | avg: 0.259 ms | max: 36.157 ms | sum:33588.933 ms |
dav1d-worker:(8) | 162369.504 ms | 411962 | avg: 0.682 ms | max: 30.648 ms | sum:280864.249 ms |
ThreadPoolForeg:(13) | 21177.187 ms | 60907 | avg: 0.401 ms | max: 30.424 ms | sum:24412.770 ms |
gmain:(3) | 95.617 ms | 3552 | avg: 0.755 ms | max: 26.365 ms | sum: 2680.738 ms |
llvmpipe-0:(2) | 24602.666 ms | 30828 | avg: 1.278 ms | max: 23.590 ms | sum:39408.811 ms |
llvmpipe-2:(2) | 27707.699 ms | 29226 | avg: 1.236 ms | max: 23.579 ms | sum:36126.717 ms |
llvmpipe-7:(2) | 34437.755 ms | 27017 | avg: 1.097 ms | max: 23.545 ms | sum:29634.448 ms |
llvmpipe-5:(2) | 24533.947 ms | 28503 | avg: 1.375 ms | max: 22.995 ms | sum:39191.132 ms |
-----------------------------------------------------------------------------------------------------------
TOTAL: |2314609.811 ms | 2473891 | 96.4% util, 27.7% GUI 41.796 ms | 1361629.825 ms |
-----------------------------------------------------------------------------------------------------------
perf.data.eevdf.full sort=max - top 10 summary
-----------------------------------------------------------------------------------------------------------
Task | Runtime ms | Switches | Avg delay ms | Max delay ms | Sum delay ms |
-----------------------------------------------------------------------------------------------------------
chrome:(8) | 6329.996 ms | 80080 | avg: 0.193 ms | max: 28.835 ms | sum:15432.012 ms |
ThreadPoolForeg:(20) | 20477.539 ms | 158457 | avg: 0.265 ms | max: 25.708 ms | sum:42003.063 ms |
dav1d-worker:(8) | 168022.569 ms | 1090719 | avg: 0.366 ms | max: 24.786 ms | sum:398971.023 ms |
massive_intr:(8) |1736052.944 ms | 721103 | avg: 0.658 ms | max: 23.427 ms | sum:474493.391 ms |
llvmpipe-5:(2) | 22970.555 ms | 31184 | avg: 1.448 ms | max: 22.465 ms | sum:45148.667 ms |
llvmpipe-3:(2) | 22803.121 ms | 31688 | avg: 1.436 ms | max: 22.076 ms | sum:45516.196 ms |
llvmpipe-0:(2) | 22050.612 ms | 33580 | avg: 1.397 ms | max: 22.007 ms | sum:46898.028 ms |
VizCompositorTh:5538 | 90856.230 ms | 91865 | avg: 0.605 ms | max: 21.702 ms | sum:55542.418 ms |
llvmpipe-1:(2) | 22866.426 ms | 32870 | avg: 1.390 ms | max: 20.732 ms | sum:45690.066 ms |
llvmpipe-2:(2) | 22672.646 ms | 32319 | avg: 1.415 ms | max: 20.647 ms | sum:45731.838 ms |
-----------------------------------------------------------------------------------------------------------
TOTAL: |2332092.393 ms | 3449563 | 97.1% util, 25.6% GUI 28.835 ms | 1570459.986 ms |
-----------------------------------------------------------------------------------------------------------
vs stable 1.394 distribution delta.. meaningless 1.153
next prev parent reply other threads:[~2023-03-29 9:12 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 9:26 [PATCH 00/17] sched: EEVDF using latency-nice Peter Zijlstra
2023-03-28 9:26 ` [PATCH 01/17] sched: Introduce latency-nice as a per-task attribute Peter Zijlstra
2023-03-28 9:26 ` [PATCH 02/17] sched/fair: Add latency_offset Peter Zijlstra
2023-03-28 9:26 ` [PATCH 03/17] sched/fair: Add sched group latency support Peter Zijlstra
2023-03-28 9:26 ` [PATCH 04/17] sched/fair: Add avg_vruntime Peter Zijlstra
2023-03-28 23:57 ` Josh Don
2023-03-29 7:50 ` Peter Zijlstra
2023-04-05 19:13 ` Peter Zijlstra
2023-03-28 9:26 ` [PATCH 05/17] sched/fair: Remove START_DEBIT Peter Zijlstra
2023-03-28 9:26 ` [PATCH 06/17] sched/fair: Add lag based placement Peter Zijlstra
2023-04-03 9:18 ` Chen Yu
2023-04-05 9:47 ` Peter Zijlstra
2023-04-06 3:03 ` Chen Yu
2023-04-13 15:42 ` Chen Yu
2023-04-13 15:55 ` Chen Yu
2023-03-28 9:26 ` [PATCH 07/17] rbtree: Add rb_add_augmented_cached() helper Peter Zijlstra
2023-03-28 9:26 ` [PATCH 08/17] sched/fair: Implement an EEVDF like policy Peter Zijlstra
2023-03-29 1:26 ` Josh Don
2023-03-29 8:02 ` Peter Zijlstra
2023-03-29 8:06 ` Peter Zijlstra
2023-03-29 8:22 ` Peter Zijlstra
2023-03-29 18:48 ` Josh Don
2023-03-29 8:12 ` Peter Zijlstra
2023-03-29 18:54 ` Josh Don
2023-03-29 8:18 ` Peter Zijlstra
2023-03-29 14:35 ` Vincent Guittot
2023-03-30 8:01 ` Peter Zijlstra
2023-03-30 17:05 ` Vincent Guittot
2023-04-04 12:00 ` Peter Zijlstra
2023-03-28 9:26 ` [PATCH 09/17] sched: Commit to lag based placement Peter Zijlstra
2023-03-28 9:26 ` [PATCH 10/17] sched/smp: Use lag to simplify cross-runqueue placement Peter Zijlstra
2023-03-28 9:26 ` [PATCH 11/17] sched: Commit to EEVDF Peter Zijlstra
2023-03-28 9:26 ` [PATCH 12/17] sched/debug: Rename min_granularity to base_slice Peter Zijlstra
2023-03-28 9:26 ` [PATCH 13/17] sched: Merge latency_offset into slice Peter Zijlstra
2023-03-28 9:26 ` [PATCH 14/17] sched/eevdf: Better handle mixed slice length Peter Zijlstra
2023-03-31 15:26 ` Vincent Guittot
2023-04-04 9:29 ` Peter Zijlstra
2023-04-04 13:50 ` Joel Fernandes
2023-04-05 5:41 ` Mike Galbraith
2023-04-05 8:35 ` Peter Zijlstra
2023-04-05 20:05 ` Joel Fernandes
2023-04-14 11:18 ` Phil Auld
2023-04-16 5:10 ` Joel Fernandes
[not found] ` <20230401232355.336-1-hdanton@sina.com>
2023-04-02 2:40 ` Mike Galbraith
2023-03-28 9:26 ` [PATCH 15/17] [RFC] sched/eevdf: Sleeper bonus Peter Zijlstra
2023-03-29 9:10 ` Mike Galbraith [this message]
2023-03-28 9:26 ` [PATCH 16/17] [RFC] sched/eevdf: Minimal vavg option Peter Zijlstra
2023-03-28 9:26 ` [PATCH 17/17] [DEBUG] sched/eevdf: Debug / validation crud Peter Zijlstra
2023-04-03 7:42 ` [PATCH 00/17] sched: EEVDF using latency-nice Shrikanth Hegde
2023-04-10 3:13 ` David Vernet
2023-04-11 2:09 ` David Vernet
[not found] ` <20230410082307.1327-1-hdanton@sina.com>
2023-04-11 10:15 ` Mike Galbraith
[not found] ` <20230411133333.1790-1-hdanton@sina.com>
2023-04-11 14:56 ` Mike Galbraith
[not found] ` <20230412025042.1413-1-hdanton@sina.com>
2023-04-12 4:05 ` Mike Galbraith
2023-04-25 12:32 ` Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7577c8e361ee311d019f40b8921099f3e9aa2d23.camel@gmx.de \
--to=efault@gmx.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris.hyser@oracle.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=qperret@google.com \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=timj@gnu.org \
--cc=vincent.guittot@linaro.org \
--cc=youssefesmat@chromium.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®