* [PATCH] microblaze: Fix typo in comment @ 2022-07-21 2:51 Slark Xiao 2022-07-21 6:33 ` Conor Dooley 0 siblings, 1 reply; 5+ messages in thread From: Slark Xiao @ 2022-07-21 2:51 UTC (permalink / raw) To: monstr; +Cc: linux-kernel, Slark Xiao Fix typo in the comment Signed-off-by: Slark Xiao <slark_xiao@163.com> --- arch/microblaze/kernel/entry.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S index b179f8f6d287..8651fe351276 100644 --- a/arch/microblaze/kernel/entry.S +++ b/arch/microblaze/kernel/entry.S @@ -456,7 +456,7 @@ TRAP_return: /* Make global symbol for debugging */ /* This the initial entry point for a new child thread, with an appropriate - stack in place that makes it look the the child is in the middle of an + stack in place that makes it look the child is in the middle of an syscall. This function is actually `returned to' from switch_thread (copy_thread makes ret_from_fork the return address in each new thread's saved context). */ -- 2.25.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Fix typo in comment 2022-07-21 2:51 [PATCH] microblaze: Fix typo in comment Slark Xiao @ 2022-07-21 6:33 ` Conor Dooley 2022-07-21 6:43 ` Slark Xiao 0 siblings, 1 reply; 5+ messages in thread From: Conor Dooley @ 2022-07-21 6:33 UTC (permalink / raw) To: Slark Xiao, monstr; +Cc: linux-kernel On 21/07/2022 03:51, Slark Xiao wrote: > Fix typo in the comment > > Signed-off-by: Slark Xiao <slark_xiao@163.com> > --- > arch/microblaze/kernel/entry.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S > index b179f8f6d287..8651fe351276 100644 > --- a/arch/microblaze/kernel/entry.S > +++ b/arch/microblaze/kernel/entry.S > @@ -456,7 +456,7 @@ TRAP_return: /* Make global symbol for debugging */ > > > /* This the initial entry point for a new child thread, with an appropriate > - stack in place that makes it look the the child is in the middle of an > + stack in place that makes it look the child is in the middle of an This is /a/ fix, but I don't think it is the right one for this comment. Surely this should be "s/the the/like the/, no? Thanks, Conor. > syscall. This function is actually `returned to' from switch_thread > (copy_thread makes ret_from_fork the return address in each new thread's > saved context). */ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH] microblaze: Fix typo in comment 2022-07-21 6:33 ` Conor Dooley @ 2022-07-21 6:43 ` Slark Xiao 2022-07-21 6:53 ` Conor Dooley 0 siblings, 1 reply; 5+ messages in thread From: Slark Xiao @ 2022-07-21 6:43 UTC (permalink / raw) To: Conor Dooley; +Cc: monstr, linux-kernel Hi Conor, Thanks for your reply. Actually I didn't get your point of 'Surely this should be "s/the the/like the/, no?'. Do you mean this is NOT a TYPO, but like a change which we use 'the/' instead of 'the the/'? Thanks! At 2022-07-21 14:33:32, "Conor Dooley" <mail@conchuod.ie> wrote: > >On 21/07/2022 03:51, Slark Xiao wrote: >> Fix typo in the comment >> >> Signed-off-by: Slark Xiao <slark_xiao@163.com> >> --- >> arch/microblaze/kernel/entry.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S >> index b179f8f6d287..8651fe351276 100644 >> --- a/arch/microblaze/kernel/entry.S >> +++ b/arch/microblaze/kernel/entry.S >> @@ -456,7 +456,7 @@ TRAP_return: /* Make global symbol for debugging */ >> >> >> /* This the initial entry point for a new child thread, with an appropriate >> - stack in place that makes it look the the child is in the middle of an >> + stack in place that makes it look the child is in the middle of an > >This is /a/ fix, but I don't think it is the right one for this comment. >Surely this should be "s/the the/like the/, no? >Thanks, >Conor. > >> syscall. This function is actually `returned to' from switch_thread >> (copy_thread makes ret_from_fork the return address in each new thread's >> saved context). */ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Fix typo in comment 2022-07-21 6:43 ` Slark Xiao @ 2022-07-21 6:53 ` Conor Dooley 2022-07-21 7:08 ` Slark Xiao 0 siblings, 1 reply; 5+ messages in thread From: Conor Dooley @ 2022-07-21 6:53 UTC (permalink / raw) To: Slark Xiao; +Cc: monstr, linux-kernel Hey Slark, On the list we reply "inline" rather than at the top of the quoted email. This makes things easier to follow. I fixed up your reply, see below ;) On 21/07/2022 07:43, Slark Xiao wrote: > > At 2022-07-21 14:33:32, "Conor Dooley" <mail@conchuod.ie> wrote: >> >> On 21/07/2022 03:51, Slark Xiao wrote: >>> Fix typo in the comment >>> >>> Signed-off-by: Slark Xiao <slark_xiao@163.com> >>> --- >>> arch/microblaze/kernel/entry.S | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S >>> index b179f8f6d287..8651fe351276 100644 >>> --- a/arch/microblaze/kernel/entry.S >>> +++ b/arch/microblaze/kernel/entry.S >>> @@ -456,7 +456,7 @@ TRAP_return: /* Make global symbol for debugging */ >>> >>> >>> /* This the initial entry point for a new child thread, with an appropriate >>> - stack in place that makes it look the the child is in the middle of an >>> + stack in place that makes it look the child is in the middle of an >> >> This is /a/ fix, but I don't think it is the right one for this comment. >> Surely this should be "s/the the/like the/, no? > > Thanks for your reply. > Actually I didn't get your point of 'Surely this should be "s/the the/like the/, no?'. > Do you mean this is NOT a TYPO, but like a change which we use 'the/' instead of 'the the/'? What I meant was that the sentence does not make very much sense, either now or with your patch applied. I do think that "the the" is a mistake, but to me the correct fix is replacing it with "like the" rather than "the". The new sentence would read: "stack in place that makes it look like the child is in the middle of an" Oh, also - there's another typo in this line. "an syscall" should be "a syscall". Thanks, Conor. > > Thanks! >> >>> syscall. This function is actually `returned to' from switch_thread >>> (copy_thread makes ret_from_fork the return address in each new thread's >>> saved context). */ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH] microblaze: Fix typo in comment 2022-07-21 6:53 ` Conor Dooley @ 2022-07-21 7:08 ` Slark Xiao 0 siblings, 0 replies; 5+ messages in thread From: Slark Xiao @ 2022-07-21 7:08 UTC (permalink / raw) To: Conor Dooley; +Cc: monstr, linux-kernel At 2022-07-21 14:53:30, "Conor Dooley" <mail@conchuod.ie> wrote: > >Hey Slark, >On the list we reply "inline" rather than at the top of the >quoted email. This makes things easier to follow. >I fixed up your reply, see below ;) > >On 21/07/2022 07:43, Slark Xiao wrote: >> >> At 2022-07-21 14:33:32, "Conor Dooley" <mail@conchuod.ie> wrote: >>> >>> On 21/07/2022 03:51, Slark Xiao wrote: >>>> Fix typo in the comment >>>> >>>> Signed-off-by: Slark Xiao <slark_xiao@163.com> >>>> --- >>>> arch/microblaze/kernel/entry.S | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S >>>> index b179f8f6d287..8651fe351276 100644 >>>> --- a/arch/microblaze/kernel/entry.S >>>> +++ b/arch/microblaze/kernel/entry.S >>>> @@ -456,7 +456,7 @@ TRAP_return: /* Make global symbol for debugging */ >>>> >>>> >>>> /* This the initial entry point for a new child thread, with an appropriate >>>> - stack in place that makes it look the the child is in the middle of an >>>> + stack in place that makes it look the child is in the middle of an >>> >>> This is /a/ fix, but I don't think it is the right one for this comment. >>> Surely this should be "s/the the/like the/, no? >> >> Thanks for your reply. >> Actually I didn't get your point of 'Surely this should be "s/the the/like the/, no?'. >> Do you mean this is NOT a TYPO, but like a change which we use 'the/' instead of 'the the/'? > >What I meant was that the sentence does not make very much sense, either now >or with your patch applied. I do think that "the the" is a mistake, but to me >the correct fix is replacing it with "like the" rather than "the". >The new sentence would read: >"stack in place that makes it look like the child is in the middle of an" > >Oh, also - there's another typo in this line. "an syscall" should be "a syscall". >Thanks, >Conor. This time I get what you said. Actually I have committed about 20 commits about this typo. I searched it in whole project to see which file use 'the the'. So I miss checking about the sentence real meaning, just like in this change. Also, some maintainers would like to reply me in the top of quoted email. So it's hard for me to pick the 'correct' behavior. Anyway, I will insist on replying it in 'inline' and a version v2 would be commit. Thanks! > >> >> Thanks! >>> >>>> syscall. This function is actually `returned to' from switch_thread >>>> (copy_thread makes ret_from_fork the return address in each new thread's >>>> saved context). */ ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-21 7:09 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-07-21 2:51 [PATCH] microblaze: Fix typo in comment Slark Xiao 2022-07-21 6:33 ` Conor Dooley 2022-07-21 6:43 ` Slark Xiao 2022-07-21 6:53 ` Conor Dooley 2022-07-21 7:08 ` Slark Xiao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®