Re: Linux 2.6.11-rc2: vmnet breaks; put skb_copy_datagram b

Re: Linux 2.6.11-rc2: vmnet breaks; put skb_copy_datagram b

[Petr Vandrovec]

On 25 Jan 05 at 1:41, Sytse Wielinga wrote:
> Linus, could you please put skb_copy_datagram back in place? It's not used
> anymore in the kernel, but the vmnet module (in vmware) still uses this
> interface to skb_copy_datagram_iovec.

There is no reason for doing this.  Just grab latest vmmon & vmnet
from http://platan.vc.cvut.cz/ftp/pub/vmware/vmware-any-any-update89.tar.gz,
and enjoy latest and greatest modules.  Besides this one you'll get lot
of other fixes and improvements for free ;-)
                                                Petr Vandrovec

Re: Linux 2.6.11-rc2: vmnet breaks; put skb_copy_datagram b

[Sytse Wielinga]

On Tue, Jan 25, 2005 at 02:46:56AM +0100, Petr Vandrovec wrote:
> On 25 Jan 05 at 1:41, Sytse Wielinga wrote:
> > Linus, could you please put skb_copy_datagram back in place? It's not used
> > anymore in the kernel, but the vmnet module (in vmware) still uses this
> > interface to skb_copy_datagram_iovec.
> 
> There is no reason for doing this.  Just grab latest vmmon & vmnet
> from http://platan.vc.cvut.cz/ftp/pub/vmware/vmware-any-any-update89.tar.gz,
> and enjoy latest and greatest modules.  Besides this one you'll get lot
> of other fixes and improvements for free ;-)

I'm very sorry, you're completely right. That version uses
skb_copy_datagram_iovec. I'll file a bug for gentoo instead, that it needs to
update from 88 to 89.

On the other hand, though, I would think it would be a good idea to leave this
function in until after 2.6.11, so that distributions and people have plenty of
time to update their vmware. After all, it's not like we'd be missing out on an
important fix or something; we're just moving a couple of bytes out of the
kernel into vmnet.

    Sytse