From: Marek Vasut <marek.vasut@mailbox.org>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Ethan Tidmore <ethantidmore06@gmail.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Joseph Guo <qijian.guo@nxp.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug
Date: Mon, 16 Mar 2026 23:55:12 +0100 [thread overview]
Message-ID: <75be8726-ad91-445d-b407-f438e76ff5cc@mailbox.org> (raw)
In-Reply-To: <DGY7EL00XS8C.L5V6X9997G67@bootlin.com>
On 3/9/26 12:10 PM, Luca Ceresoli wrote:
> On Sat Mar 7, 2026 at 4:32 AM CET, Ethan Tidmore wrote:
>> The function drm_of_get_data_lanes_count_ep() returns negative error
>> codes and dsi->lanes is an unsigned integer, so the check (dsi->lanes <
>> 0) is always impossible.
>>
>> Make the return value of drm_of_get_data_lanes_count_ep() be assigned to
>> ret, check for error, and then assign dsi->lanes to ret.
>>
>> Detected by Smatch:
>> drivers/gpu/drm/bridge/waveshare-dsi.c:70 ws_bridge_attach_dsi() warn:
>> unsigned 'dsi->lanes' is never less than zero.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202603060341.hNj0pl9L-lkp@intel.com/
>> Fixes: fca11428425e9 ("drm/bridge: waveshare-dsi: Add support for 1..4 DSI data lanes")
>> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
(it seems FDO patchwork did not pick this up)
next prev parent reply other threads:[~2026-03-16 22:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 3:32 Ethan Tidmore
2026-03-07 3:44 ` Marek Vasut
2026-03-07 6:42 ` Ethan Tidmore
2026-03-07 15:57 ` Marek Vasut
2026-03-09 11:10 ` Luca Ceresoli
2026-03-16 22:55 ` Marek Vasut [this message]
2026-03-17 17:07 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75be8726-ad91-445d-b407-f438e76ff5cc@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ethantidmore06@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=qijian.guo@nxp.com \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®