mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Joe Perches <joe@perches.com>,
	Jes Sorensen <jes.sorensen@gmail.com>,
	Kalle Valo <kvalo@codeaurora.org>
Cc: Daniel Drake <dsd@gentoo.org>,
	Ulrich Kunitz <kune@deine-taler.de>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH][next] zd1211rw/zd_usb.h: Replace zero-length array with flexible-array member
Date: Tue, 10 Mar 2020 17:46:59 -0500	[thread overview]
Message-ID: <75c0c37a-82bf-507e-d6ea-89cd56add8a7@embeddedor.com> (raw)
In-Reply-To: <ac0ab948aabd201360d9330c206dd72df14847ae.camel@perches.com>



On 3/10/20 5:41 PM, Joe Perches wrote:
> On Tue, 2020-03-10 at 18:33 -0400, Jes Sorensen wrote:
>> Again, the changes are not harmful to the code, but add no value.
> 
> That argument asserts that style consistency is value-free.
> I generally disagree with that argument.
> 

If this is a matter of style, then I have already proved (this is in
the changelog text) that the [] style is better than the [0] style:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=76497732932f15e7323dc805e8ea8dc11bb587cf

> But then again, it's likely we will have to agree to disagree.
> 

That's a healthy thing. :)

Thanks
--
Gustavo

  reply	other threads:[~2020-03-10 22:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 11:12 Gustavo A. R. Silva
2020-03-05 14:50 ` Kalle Valo
2020-03-05 15:20   ` Joe Perches
2020-03-05 16:10     ` Kalle Valo
2020-03-05 18:28       ` Gustavo A. R. Silva
2020-03-10 13:56         ` Kalle Valo
2020-03-10 21:52           ` Gustavo A. R. Silva
2020-03-10 22:07             ` Jes Sorensen
2020-03-10 22:13               ` Gustavo A. R. Silva
2020-03-10 22:15                 ` Joe Perches
2020-03-10 22:21                   ` Gustavo A. R. Silva
2020-03-10 22:28                     ` Joe Perches
2020-03-10 22:33                       ` Jes Sorensen
2020-03-10 22:41                         ` Joe Perches
2020-03-10 22:46                           ` Gustavo A. R. Silva [this message]
2020-03-10 22:33                       ` Gustavo A. R. Silva
2020-03-10 22:20                 ` Jes Sorensen
2020-03-10 22:31                   ` Gustavo A. R. Silva
2020-03-10 22:34                     ` Jes Sorensen
2020-03-10 22:36                       ` Gustavo A. R. Silva
2020-03-23 16:46                         ` Kalle Valo
2020-03-23 17:14 ` [PATCH][next] zd1211rw: " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75c0c37a-82bf-507e-d6ea-89cd56add8a7@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=davem@davemloft.net \
    --cc=dsd@gentoo.org \
    --cc=jes.sorensen@gmail.com \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=kune@deine-taler.de \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome