From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Jes Sorensen <jes.sorensen@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: Daniel Drake <dsd@gentoo.org>,
Ulrich Kunitz <kune@deine-taler.de>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] zd1211rw/zd_usb.h: Replace zero-length array with flexible-array member
Date: Tue, 10 Mar 2020 15:28:52 -0700 [thread overview]
Message-ID: <8b6213e51131deacbdac29a8d9c088ae49933724.camel@perches.com> (raw)
In-Reply-To: <c2aa4d8d-1c39-1903-2b49-382f2143e181@embeddedor.com>
On Tue, 2020-03-10 at 17:21 -0500, Gustavo A. R. Silva wrote:
> On 3/10/20 5:15 PM, Joe Perches wrote:
> > As far as I can tell, it doesn't actually make a difference as
> > all the compilers produce the same object code with either form.
> >
>
> That's precisely why we can implement these changes, cleanly(the fact
> that the compiler produces the same object code). So, the resulting
> object code is not the point here.
You are making Jes' point.
There's nothing wrong with making changes just for consistent
style across the kernel.
This change is exactly that.
I have no objection to this patch.
Jes does, though Jes is not a maintainer of this file.
I think "churn" arguments are overstated.
next prev parent reply other threads:[~2020-03-10 22:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 11:12 Gustavo A. R. Silva
2020-03-05 14:50 ` Kalle Valo
2020-03-05 15:20 ` Joe Perches
2020-03-05 16:10 ` Kalle Valo
2020-03-05 18:28 ` Gustavo A. R. Silva
2020-03-10 13:56 ` Kalle Valo
2020-03-10 21:52 ` Gustavo A. R. Silva
2020-03-10 22:07 ` Jes Sorensen
2020-03-10 22:13 ` Gustavo A. R. Silva
2020-03-10 22:15 ` Joe Perches
2020-03-10 22:21 ` Gustavo A. R. Silva
2020-03-10 22:28 ` Joe Perches [this message]
2020-03-10 22:33 ` Jes Sorensen
2020-03-10 22:41 ` Joe Perches
2020-03-10 22:46 ` Gustavo A. R. Silva
2020-03-10 22:33 ` Gustavo A. R. Silva
2020-03-10 22:20 ` Jes Sorensen
2020-03-10 22:31 ` Gustavo A. R. Silva
2020-03-10 22:34 ` Jes Sorensen
2020-03-10 22:36 ` Gustavo A. R. Silva
2020-03-23 16:46 ` Kalle Valo
2020-03-23 17:14 ` [PATCH][next] zd1211rw: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6213e51131deacbdac29a8d9c088ae49933724.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=gustavo@embeddedor.com \
--cc=jes.sorensen@gmail.com \
--cc=kune@deine-taler.de \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®