mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe
@ 2026-06-29 19:22 Loic Poulain
  2026-06-29 19:22 ` [PATCH 1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains Loic Poulain
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Loic Poulain @ 2026-06-29 19:22 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
	Imran Shaik, Taniya Das
  Cc: linux-arm-msm, linux-clk, linux-kernel, Loic Poulain

Neither the USB nor PCIe host controller drivers currently handle
state loss across suspend on this platform. To address this, switch the
corresponding GDSCs to retention mode (PWRSTS_RET_ON), matching the
behavior already used on similar Qualcomm SoCs.

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
---
Loic Poulain (2):
      clk: qcom: gcc-qcs8300: Use retention for PCIe power domains
      clk: qcom: gcc-qcs8300: Use retention for USB power domains

 drivers/clk/qcom/gcc-qcs8300.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260629-monza-suspend-f8c18aa7f364

Best regards,
-- 
Loic Poulain <loic.poulain@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains
  2026-06-29 19:22 [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Loic Poulain
@ 2026-06-29 19:22 ` Loic Poulain
  2026-06-30 10:41   ` Konrad Dybcio
  2026-06-29 19:22 ` [PATCH 2/2] clk: qcom: gcc-qcs8300: Use retention for USB " Loic Poulain
  2026-07-08 14:56 ` [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Bjorn Andersson
  2 siblings, 1 reply; 6+ messages in thread
From: Loic Poulain @ 2026-06-29 19:22 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
	Imran Shaik, Taniya Das
  Cc: linux-arm-msm, linux-clk, linux-kernel, Loic Poulain

As the PCIe host controller driver does not yet support dealing with the
loss of state during suspend, use retention for relevant GDSCs.

Fix the PCIe link not surviving upon resume, and GDSC error:
  gcc_pcie_0_gdsc status stuck at 'off'

Fixes: 95eeb2ffce73 ("clk: qcom: Add support for Global Clock Controller on QCS8300")
Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
---
 drivers/clk/qcom/gcc-qcs8300.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-qcs8300.c b/drivers/clk/qcom/gcc-qcs8300.c
index 80831c7dea3bcde0ced46054783df02b07a985db..009672b75fb9099cb0c6db7af3863654f2fa6648 100644
--- a/drivers/clk/qcom/gcc-qcs8300.c
+++ b/drivers/clk/qcom/gcc-qcs8300.c
@@ -3268,7 +3268,7 @@ static struct gdsc gcc_pcie_0_gdsc = {
 	.pd = {
 		.name = "gcc_pcie_0_gdsc",
 	},
-	.pwrsts = PWRSTS_OFF_ON,
+	.pwrsts = PWRSTS_RET_ON,
 	.flags = VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR,
 };
 
@@ -3282,7 +3282,7 @@ static struct gdsc gcc_pcie_1_gdsc = {
 	.pd = {
 		.name = "gcc_pcie_1_gdsc",
 	},
-	.pwrsts = PWRSTS_OFF_ON,
+	.pwrsts = PWRSTS_RET_ON,
 	.flags = VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR,
 };
 

-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] clk: qcom: gcc-qcs8300: Use retention for USB power domains
  2026-06-29 19:22 [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Loic Poulain
  2026-06-29 19:22 ` [PATCH 1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains Loic Poulain
@ 2026-06-29 19:22 ` Loic Poulain
  2026-06-30 10:41   ` Konrad Dybcio
  2026-07-08 14:56 ` [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Bjorn Andersson
  2 siblings, 1 reply; 6+ messages in thread
From: Loic Poulain @ 2026-06-29 19:22 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Brian Masney,
	Imran Shaik, Taniya Das
  Cc: linux-arm-msm, linux-clk, linux-kernel, Loic Poulain

The USB subsystem does not expect to lose its state on suspend:

  xhci-hcd xhci-hcd.1.auto: xHC error in resume, USBSTS 0x401, Reinit
  usb usb1: root hub lost power or was reset

To maintain state during suspend, the relevant GDSCs need to stay in
retention mode, like they do on other similar SoCs. Change the mode to
PWRSTS_RET_ON to fix.

Fixes: 95eeb2ffce73 ("clk: qcom: Add support for Global Clock Controller on QCS8300")
Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
---
 drivers/clk/qcom/gcc-qcs8300.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-qcs8300.c b/drivers/clk/qcom/gcc-qcs8300.c
index 009672b75fb9099cb0c6db7af3863654f2fa6648..fe0632687f9f0ec7c8205bd2daa31786373ff55d 100644
--- a/drivers/clk/qcom/gcc-qcs8300.c
+++ b/drivers/clk/qcom/gcc-qcs8300.c
@@ -3306,7 +3306,7 @@ static struct gdsc gcc_usb20_prim_gdsc = {
 	.pd = {
 		.name = "gcc_usb20_prim_gdsc",
 	},
-	.pwrsts = PWRSTS_OFF_ON,
+	.pwrsts = PWRSTS_RET_ON,
 	.flags = RETAIN_FF_ENABLE | POLL_CFG_GDSCR,
 };
 
@@ -3318,7 +3318,7 @@ static struct gdsc gcc_usb30_prim_gdsc = {
 	.pd = {
 		.name = "gcc_usb30_prim_gdsc",
 	},
-	.pwrsts = PWRSTS_OFF_ON,
+	.pwrsts = PWRSTS_RET_ON,
 	.flags = RETAIN_FF_ENABLE | POLL_CFG_GDSCR,
 };
 

-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains
  2026-06-29 19:22 ` [PATCH 1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains Loic Poulain
@ 2026-06-30 10:41   ` Konrad Dybcio
  0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2026-06-30 10:41 UTC (permalink / raw)
  To: Loic Poulain, Bjorn Andersson, Michael Turquette, Stephen Boyd,
	Brian Masney, Imran Shaik, Taniya Das
  Cc: linux-arm-msm, linux-clk, linux-kernel

On 6/29/26 9:22 PM, Loic Poulain wrote:
> As the PCIe host controller driver does not yet support dealing with the
> loss of state during suspend, use retention for relevant GDSCs.
> 
> Fix the PCIe link not surviving upon resume, and GDSC error:
>   gcc_pcie_0_gdsc status stuck at 'off'
> 
> Fixes: 95eeb2ffce73 ("clk: qcom: Add support for Global Clock Controller on QCS8300")

"fixes" is stretching it a bit, given the problem lies elsewhere,
but okay..

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] clk: qcom: gcc-qcs8300: Use retention for USB power domains
  2026-06-29 19:22 ` [PATCH 2/2] clk: qcom: gcc-qcs8300: Use retention for USB " Loic Poulain
@ 2026-06-30 10:41   ` Konrad Dybcio
  0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2026-06-30 10:41 UTC (permalink / raw)
  To: Loic Poulain, Bjorn Andersson, Michael Turquette, Stephen Boyd,
	Brian Masney, Imran Shaik, Taniya Das
  Cc: linux-arm-msm, linux-clk, linux-kernel

On 6/29/26 9:22 PM, Loic Poulain wrote:
> The USB subsystem does not expect to lose its state on suspend:
> 
>   xhci-hcd xhci-hcd.1.auto: xHC error in resume, USBSTS 0x401, Reinit
>   usb usb1: root hub lost power or was reset
> 
> To maintain state during suspend, the relevant GDSCs need to stay in
> retention mode, like they do on other similar SoCs. Change the mode to
> PWRSTS_RET_ON to fix.
> 
> Fixes: 95eeb2ffce73 ("clk: qcom: Add support for Global Clock Controller on QCS8300")
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe
  2026-06-29 19:22 [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Loic Poulain
  2026-06-29 19:22 ` [PATCH 1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains Loic Poulain
  2026-06-29 19:22 ` [PATCH 2/2] clk: qcom: gcc-qcs8300: Use retention for USB " Loic Poulain
@ 2026-07-08 14:56 ` Bjorn Andersson
  2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2026-07-08 14:56 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Brian Masney, Imran Shaik,
	Taniya Das, Loic Poulain
  Cc: linux-arm-msm, linux-clk, linux-kernel


On Mon, 29 Jun 2026 21:22:54 +0200, Loic Poulain wrote:
> Neither the USB nor PCIe host controller drivers currently handle
> state loss across suspend on this platform. To address this, switch the
> corresponding GDSCs to retention mode (PWRSTS_RET_ON), matching the
> behavior already used on similar Qualcomm SoCs.
> 
> 

Applied, thanks!

[1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains
      commit: 11b170abe4d324cac0d15a410282d1ec2b6bafa0
[2/2] clk: qcom: gcc-qcs8300: Use retention for USB power domains
      commit: d8638610e0c9ebab2800b7ad6c2c2a3737090da9

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-07-08 14:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-29 19:22 [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Loic Poulain
2026-06-29 19:22 ` [PATCH 1/2] clk: qcom: gcc-qcs8300: Use retention for PCIe power domains Loic Poulain
2026-06-30 10:41   ` Konrad Dybcio
2026-06-29 19:22 ` [PATCH 2/2] clk: qcom: gcc-qcs8300: Use retention for USB " Loic Poulain
2026-06-30 10:41   ` Konrad Dybcio
2026-07-08 14:56 ` [PATCH 0/2] clk: qcom: gcc-qcs8300: Fix suspend/resume issues for USB and PCIe Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®