mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Francesco Dolcini <francesco@dolcini.it>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	linux-kernel@vger.kernel.org, Faiz Abbas <faiz_abbas@ti.com>
Subject: Re: [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity
Date: Tue, 7 Mar 2023 08:53:02 +0200	[thread overview]
Message-ID: <75d48dce-192f-0950-8770-839cfb53588b@intel.com> (raw)
In-Reply-To: <20230306162751.163369-1-francesco@dolcini.it>

On 6/03/23 18:27, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Lower the power-on failed message severity from warn to info when the
> controller does not power-up. It's normal to have this situation when
> the SD card slot is empty, therefore we should not warn the user about
> it.
> 
> Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci_am654.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 7ef828942df3..89953093e20c 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg)
>  					MAX_POWER_ON_TIMEOUT, false, host, val,
>  					reg);
>  		if (ret)
> -			dev_warn(mmc_dev(host->mmc), "Power on failed\n");
> +			dev_info(mmc_dev(host->mmc), "Power on failed\n");
>  	}
>  }
>  


  reply	other threads:[~2023-03-07  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 16:27 Francesco Dolcini
2023-03-07  6:53 ` Adrian Hunter [this message]
2023-03-09 15:02 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75d48dce-192f-0950-8770-839cfb53588b@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=faiz_abbas@ti.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®