* [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity
@ 2023-03-06 16:27 Francesco Dolcini
2023-03-07 6:53 ` Adrian Hunter
2023-03-09 15:02 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Francesco Dolcini @ 2023-03-06 16:27 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Francesco Dolcini, linux-kernel, Adrian Hunter, Faiz Abbas
From: Francesco Dolcini <francesco.dolcini@toradex.com>
Lower the power-on failed message severity from warn to info when the
controller does not power-up. It's normal to have this situation when
the SD card slot is empty, therefore we should not warn the user about
it.
Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
drivers/mmc/host/sdhci_am654.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index 7ef828942df3..89953093e20c 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg)
MAX_POWER_ON_TIMEOUT, false, host, val,
reg);
if (ret)
- dev_warn(mmc_dev(host->mmc), "Power on failed\n");
+ dev_info(mmc_dev(host->mmc), "Power on failed\n");
}
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity
2023-03-06 16:27 [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity Francesco Dolcini
@ 2023-03-07 6:53 ` Adrian Hunter
2023-03-09 15:02 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2023-03-07 6:53 UTC (permalink / raw)
To: Francesco Dolcini, Ulf Hansson, linux-mmc
Cc: Francesco Dolcini, linux-kernel, Faiz Abbas
On 6/03/23 18:27, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Lower the power-on failed message severity from warn to info when the
> controller does not power-up. It's normal to have this situation when
> the SD card slot is empty, therefore we should not warn the user about
> it.
>
> Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 7ef828942df3..89953093e20c 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg)
> MAX_POWER_ON_TIMEOUT, false, host, val,
> reg);
> if (ret)
> - dev_warn(mmc_dev(host->mmc), "Power on failed\n");
> + dev_info(mmc_dev(host->mmc), "Power on failed\n");
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity
2023-03-06 16:27 [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity Francesco Dolcini
2023-03-07 6:53 ` Adrian Hunter
@ 2023-03-09 15:02 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2023-03-09 15:02 UTC (permalink / raw)
To: Francesco Dolcini
Cc: linux-mmc, Francesco Dolcini, linux-kernel, Adrian Hunter, Faiz Abbas
On Mon, 6 Mar 2023 at 17:27, Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Lower the power-on failed message severity from warn to info when the
> controller does not power-up. It's normal to have this situation when
> the SD card slot is empty, therefore we should not warn the user about
> it.
>
> Fixes: 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect debounce timer")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 7ef828942df3..89953093e20c 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -369,7 +369,7 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg)
> MAX_POWER_ON_TIMEOUT, false, host, val,
> reg);
> if (ret)
> - dev_warn(mmc_dev(host->mmc), "Power on failed\n");
> + dev_info(mmc_dev(host->mmc), "Power on failed\n");
> }
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-09 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-06 16:27 [PATCH v1] mmc: sdhci_am654: lower power-on failed message severity Francesco Dolcini
2023-03-07 6:53 ` Adrian Hunter
2023-03-09 15:02 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®