* [PATCH] drivers: ipa: print dev_err info accurately
@ 2020-05-25 6:29 Wang Wenhu
2020-05-26 0:49 ` Alex Elder
2020-05-26 1:04 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wang Wenhu @ 2020-05-25 6:29 UTC (permalink / raw)
To: davem, elder, netdev, linux-kernel; +Cc: kernel, Wang Wenhu
Print certain name string instead of hard-coded "memory" for dev_err
output, which would be more accurate and helpful for debugging.
Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
Cc: Alex Elder <elder@kernel.org>
---
drivers/net/ipa/ipa_clock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
index ddbd687fe64b..749ff5668e37 100644
--- a/drivers/net/ipa/ipa_clock.c
+++ b/drivers/net/ipa/ipa_clock.c
@@ -66,8 +66,8 @@ ipa_interconnect_init_one(struct device *dev, const char *name)
path = of_icc_get(dev, name);
if (IS_ERR(path))
- dev_err(dev, "error %ld getting memory interconnect\n",
- PTR_ERR(path));
+ dev_err(dev, "error %ld getting %s interconnect\n",
+ PTR_ERR(path), name);
return path;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: ipa: print dev_err info accurately
2020-05-25 6:29 [PATCH] drivers: ipa: print dev_err info accurately Wang Wenhu
@ 2020-05-26 0:49 ` Alex Elder
2020-05-26 1:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2020-05-26 0:49 UTC (permalink / raw)
To: Wang Wenhu, davem, elder, netdev, linux-kernel; +Cc: kernel
On 5/25/20 1:29 AM, Wang Wenhu wrote:
> Print certain name string instead of hard-coded "memory" for dev_err
> output, which would be more accurate and helpful for debugging.
>
> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
> Cc: Alex Elder <elder@kernel.org>
Good idea.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/ipa_clock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
> index ddbd687fe64b..749ff5668e37 100644
> --- a/drivers/net/ipa/ipa_clock.c
> +++ b/drivers/net/ipa/ipa_clock.c
> @@ -66,8 +66,8 @@ ipa_interconnect_init_one(struct device *dev, const char *name)
>
> path = of_icc_get(dev, name);
> if (IS_ERR(path))
> - dev_err(dev, "error %ld getting memory interconnect\n",
> - PTR_ERR(path));
> + dev_err(dev, "error %ld getting %s interconnect\n",
> + PTR_ERR(path), name);
>
> return path;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: ipa: print dev_err info accurately
2020-05-25 6:29 [PATCH] drivers: ipa: print dev_err info accurately Wang Wenhu
2020-05-26 0:49 ` Alex Elder
@ 2020-05-26 1:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-26 1:04 UTC (permalink / raw)
To: wenhu.wang; +Cc: elder, netdev, linux-kernel, kernel
From: Wang Wenhu <wenhu.wang@vivo.com>
Date: Sun, 24 May 2020 23:29:51 -0700
> Print certain name string instead of hard-coded "memory" for dev_err
> output, which would be more accurate and helpful for debugging.
>
> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-26 1:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 6:29 [PATCH] drivers: ipa: print dev_err info accurately Wang Wenhu
2020-05-26 0:49 ` Alex Elder
2020-05-26 1:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®