mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Rishik Yechuri <epicrishik@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rishik Yechuri <rishik.yechuri.code@gmail.com>
Subject: RE: [PATCH rtw-next 2/6] wifi: rtlwifi: use struct ieee80211_hdr for the reserved page headers
Date: Tue, 17 Nov 2026 02:24:54 +0000	[thread overview]
Message-ID: <75f8e871e5be4b568ada3f6e4f88e662@realtek.com> (raw)
In-Reply-To: <20261110184409.42205-3-rishik.yechuri.code@gmail.com>

Rishik Yechuri <epicrishik@gmail.com> wrote:
> The reserved page builders also patch the addresses of the beacon, null
> data, probe response, QoS null data, BT QoS null data and ARP response
> templates with SET_80211_HDR_ADDRESS1(), SET_80211_HDR_ADDRESS2() and
> SET_80211_HDR_ADDRESS3() from base.h. These add a hard coded byte
> offset to a u8 pointer and copy the six bytes one at a time through
> the CP_MACADDR() macro in wifi.h.
> 
> struct ieee80211_hdr from <linux/ieee80211.h> has the addr1, addr2 and
> addr3 members at the same offsets. 

No need this sentence. It is obvious. 
Please reword commit messages generated by LLM across whole patchset.

> Point at each template with that
> struct and copy the addresses with ether_addr_copy() on the members.
> Then remove the three macros, CP_MACADDR() and the FRAME_OFFSET_*
> constants, which have no other users.
> 
> No functional change intended.
> 
> Signed-off-by: Rishik Yechuri <rishik.yechuri.code@gmail.com>
> Assisted-by: Claude:claude-fable-5-1

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> index cda9388388ab..da9ef7cab2fb 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> @@ -544,18 +544,18 @@ void rtl88e_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
>         bool rtstatus;
>         u8 u1rsvdpageloc[5] = { 0 };
>         bool b_dlok = false;
> -       u8 *beacon;
> +       struct ieee80211_hdr *beacon;
>         struct ieee80211_pspoll *p_pspoll;
> -       u8 *nullfunc;
> -       u8 *p_probersp;
> +       struct ieee80211_hdr *nullfunc;
> +       struct ieee80211_hdr *p_probersp;

reverse x'mas tree



  reply	other threads:[~2026-11-17  2:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 18:44 [PATCH rtw-next 0/6] wifi: rtlwifi: replace the 802.11 header helper macros with kernel ones Rishik Yechuri
2026-11-10 18:44 ` [PATCH rtw-next 1/6] wifi: rtlwifi: use struct ieee80211_pspoll for the PS Poll reserved page Rishik Yechuri
2026-11-17  2:18   ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 2/6] wifi: rtlwifi: use struct ieee80211_hdr for the reserved page headers Rishik Yechuri
2026-11-17  2:24   ` Ping-Ke Shih [this message]
2026-11-10 18:44 ` [PATCH rtw-next 3/6] wifi: rtlwifi: call msecs_to_jiffies() directly Rishik Yechuri
2026-11-17  2:34   ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 4/6] wifi: rtlwifi: rtl8192se: use ALIGN() for the H2C command length Rishik Yechuri
2026-11-10 18:44 ` [PATCH rtw-next 5/6] wifi: rtlwifi: use ieee80211_is_ctl() instead of WLAN_FC_GET_TYPE() Rishik Yechuri
2026-11-10 18:44 ` [PATCH rtw-next 6/6] wifi: rtlwifi: remove byte(), packet_get_type() and FILL_OCTET_STRING() Rishik Yechuri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75f8e871e5be4b568ada3f6e4f88e662@realtek.com \
    --to=pkshih@realtek.com \
    --cc=epicrishik@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rishik.yechuri.code@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®