From: Ping-Ke Shih <pkshih@realtek.com>
To: Rishik Yechuri <epicrishik@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rishik Yechuri <rishik.yechuri.code@gmail.com>
Subject: RE: [PATCH rtw-next 1/6] wifi: rtlwifi: use struct ieee80211_pspoll for the PS Poll reserved page
Date: Tue, 17 Nov 2026 02:18:32 +0000 [thread overview]
Message-ID: <77b9ec4651f54eb2a3199900df69d316@realtek.com> (raw)
In-Reply-To: <20261110184409.42205-2-rishik.yechuri.code@gmail.com>
Rishik Yechuri <epicrishik@gmail.com> wrote:
> The reserved page builders fill in the PS Poll template with the
> SET_80211_PS_POLL_* macros from base.h, which write at fixed byte
> offsets into a u8 buffer. The AID macro stores a host order u16, so
> the frame is only correct on a little endian machine.
>
> Point at the template with struct ieee80211_pspoll from
> <linux/ieee80211.h> instead.
No need this sentence. It is obvious.
> Its aid member is __le16, so the AID goes
> through cpu_to_le16() and sparse can check it. The two addresses are
> copied with ether_addr_copy() on the struct members. Remove the three
> macros.
>
> On little endian systems the bytes written are the same as before.
>
> Signed-off-by: Rishik Yechuri <rishik.yechuri.code@gmail.com>
Not match the From: field
> Assisted-by: Claude:claude-fable-5-1
No need Assisted-by.
Please check the result of patchwork:
https://patchwork.kernel.org/project/linux-wireless/list/?series=1207558
[...]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> index 9a9f9e14f472..cda9388388ab 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c
> @@ -545,7 +545,7 @@ void rtl88e_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
> u8 u1rsvdpageloc[5] = { 0 };
> bool b_dlok = false;
> u8 *beacon;
> - u8 *p_pspoll;
> + struct ieee80211_pspoll *p_pspoll;
reverse x'mas tree (apply to whole patch)
> u8 *nullfunc;
> u8 *p_probersp;
>
next prev parent reply other threads:[~2026-11-17 2:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 18:44 [PATCH rtw-next 0/6] wifi: rtlwifi: replace the 802.11 header helper macros with kernel ones Rishik Yechuri
2026-11-10 18:44 ` [PATCH rtw-next 1/6] wifi: rtlwifi: use struct ieee80211_pspoll for the PS Poll reserved page Rishik Yechuri
2026-11-17 2:18 ` Ping-Ke Shih [this message]
2026-11-10 18:44 ` [PATCH rtw-next 2/6] wifi: rtlwifi: use struct ieee80211_hdr for the reserved page headers Rishik Yechuri
2026-11-17 2:24 ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 3/6] wifi: rtlwifi: call msecs_to_jiffies() directly Rishik Yechuri
2026-11-17 2:34 ` Ping-Ke Shih
2026-11-10 18:44 ` [PATCH rtw-next 4/6] wifi: rtlwifi: rtl8192se: use ALIGN() for the H2C command length Rishik Yechuri
2026-11-10 18:44 ` [PATCH rtw-next 5/6] wifi: rtlwifi: use ieee80211_is_ctl() instead of WLAN_FC_GET_TYPE() Rishik Yechuri
2026-11-10 18:44 ` [PATCH rtw-next 6/6] wifi: rtlwifi: remove byte(), packet_get_type() and FILL_OCTET_STRING() Rishik Yechuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77b9ec4651f54eb2a3199900df69d316@realtek.com \
--to=pkshih@realtek.com \
--cc=epicrishik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rishik.yechuri.code@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®