From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: linux-media@vger.kernel.org, vikash.garodia@oss.qualcomm.com,
dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev,
bod@kernel.org, mchehab@kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: qcom: iris: guard IRQ handler with runtime PM check
Date: Wed, 10 Jun 2026 14:54:43 +0200 [thread overview]
Message-ID: <760a8b79-2ea6-4a88-85b7-79c91930dd19@oss.qualcomm.com> (raw)
In-Reply-To: <CAGEkeHdK6EwVtJwSHNqJr8kufkqBsbyMMiL01SpCkzSF4bkjGQ@mail.gmail.com>
On 6/8/26 10:28 AM, Hungyu Lin wrote:
>> Have you actually hit this issue, or is it purely theoretical? We
>> shouldn't be receiving interrupts at the tail end of suspend callbacks
>> (and there's a disable_irq_nosync() right after the HW is disabled)
>
> I have not observed this on hardware.
>
> My concern comes from disable_irq_nosync().
>
> Its documentation states that it does not ensure
> existing instances of the IRQ handler have completed
> before returning.
Then let's just replace disable_irq_nosync with disable_irq,
I think this will solve this issue
Konrad
prev parent reply other threads:[~2026-06-10 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 0:11 Hungyu Lin
2026-06-08 7:54 ` Konrad Dybcio
2026-06-08 8:28 ` Hungyu Lin
2026-06-10 12:54 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760a8b79-2ea6-4a88-85b7-79c91930dd19@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®