* [PATCH v2] dt-bindings: pwm: st,pwm: convert to DT schema
@ 2026-06-18 12:42 Charan Pedumuru
2026-06-23 7:17 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Charan Pedumuru @ 2026-06-18 12:42 UTC (permalink / raw)
To: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pal Singh
Cc: linux-pwm, devicetree, linux-kernel, Charan Pedumuru
Convert STMicroelectronics STiH41x PWM/Capture controller binding
to DT schema.
Changes during conversion:
- Add 'interrupts' to the required list. The text binding listed it
as required and the driver unconditionally calls platform_get_irq().
- Drop pinctrl-0 from the required list as pinctrl properties are
inherited and validated by the pinctrl schema.
Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
Changes in v2:
- Add the missing interrupts to the required following the old binding.
- Modify commit message to explain the changes made.
- Link to v1: https://patch.msgid.link/20260613-st-pwm-v1-1-458c2c89709a@gmail.com
---
Documentation/devicetree/bindings/pwm/pwm-st.txt | 43 -----------
Documentation/devicetree/bindings/pwm/st,pwm.yaml | 93 +++++++++++++++++++++++
2 files changed, 93 insertions(+), 43 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-st.txt b/Documentation/devicetree/bindings/pwm/pwm-st.txt
deleted file mode 100644
index 19fce774cafa..000000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-st.txt
+++ /dev/null
@@ -1,43 +0,0 @@
-STMicroelectronics PWM driver bindings
---------------------------------------
-
-Required parameters:
-- compatible : "st,pwm"
-- #pwm-cells : Number of cells used to specify a PWM. First cell
- specifies the per-chip index of the PWM to use and the
- second cell is the period in nanoseconds - fixed to 2
- for STiH41x.
-- reg : Physical base address and length of the controller's
- registers.
-- pinctrl-names: Set to "default".
-- pinctrl-0: List of phandles pointing to pin configuration nodes
- for PWM module.
- For Pinctrl properties, please refer to [1].
-- clock-names: Valid entries are "pwm" and/or "capture".
-- clocks: phandle of the clock used by the PWM module.
- For Clk properties, please refer to [2].
-- interrupts: IRQ for the Capture device
-
-Optional properties:
-- st,pwm-num-chan: Number of available PWM channels. Default is 0.
-- st,capture-num-chan: Number of available Capture channels. Default is 0.
-
-[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
-[2] Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-Example:
-
-pwm1: pwm@fe510000 {
- compatible = "st,pwm";
- reg = <0xfe510000 0x68>;
- #pwm-cells = <2>;
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_pwm1_chan0_default
- &pinctrl_pwm1_chan1_default
- &pinctrl_pwm1_chan2_default
- &pinctrl_pwm1_chan3_default>;
- clocks = <&clk_sysin>;
- clock-names = "pwm";
- st,pwm-num-chan = <4>;
- st,capture-num-chan = <2>;
-};
diff --git a/Documentation/devicetree/bindings/pwm/st,pwm.yaml b/Documentation/devicetree/bindings/pwm/st,pwm.yaml
new file mode 100644
index 000000000000..a045502e0e70
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/st,pwm.yaml
@@ -0,0 +1,93 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/st,pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STiH41x PWM/Capture controller
+
+maintainers:
+ - Ajit Pal Singh <ajitpal.singh@st.com>
+
+description:
+ The STiH41x PWM controller supports both PWM output and input capture
+ functionality. It provides multiple PWM output channels for generating
+ variable duty-cycle waveforms, and multiple input capture channels for
+ measuring external signal periods and pulse widths. PWM output channels
+ and input capture channels are configured independently via
+ st,pwm-num-chan and st,capture-num-chan respectively.
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ const: st,pwm
+
+ reg:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 2
+
+ pinctrl-names:
+ const: default
+
+ clock-names:
+ items:
+ enum: [pwm, capture]
+ minItems: 1
+ maxItems: 2
+
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ interrupts:
+ description: IRQ line for the capture device.
+ maxItems: 1
+
+ st,pwm-num-chan:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Number of available PWM output channels.
+ minimum: 0
+ maximum: 4
+ default: 0
+
+ st,capture-num-chan:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Number of available input capture channels.
+ minimum: 0
+ maximum: 4
+ default: 0
+
+required:
+ - reg
+ - compatible
+ - "#pwm-cells"
+ - pinctrl-names
+ - clock-names
+ - clocks
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ pwm@fe510000 {
+ compatible = "st,pwm";
+ reg = <0xfe510000 0x68>;
+ interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH>;
+ #pwm-cells = <2>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm1_chan0_default
+ &pinctrl_pwm1_chan1_default
+ &pinctrl_pwm1_chan2_default
+ &pinctrl_pwm1_chan3_default>;
+ clocks = <&clk_sysin>;
+ clock-names = "pwm";
+ st,pwm-num-chan = <4>;
+ st,capture-num-chan = <2>;
+ };
+...
---
base-commit: c425609d6ac4012c8bbf01ec2e10e801b1923a7b
change-id: 20260613-st-pwm-1feade6cfea3
Best regards,
--
Charan Pedumuru <charan.pedumuru@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: pwm: st,pwm: convert to DT schema
2026-06-18 12:42 [PATCH v2] dt-bindings: pwm: st,pwm: convert to DT schema Charan Pedumuru
@ 2026-06-23 7:17 ` Krzysztof Kozlowski
2026-06-23 14:16 ` Charan Pedumuru
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-23 7:17 UTC (permalink / raw)
To: Charan Pedumuru
Cc: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pal Singh, linux-pwm, devicetree, linux-kernel
On Thu, Jun 18, 2026 at 12:42:07PM +0000, Charan Pedumuru wrote:
> +description:
> + The STiH41x PWM controller supports both PWM output and input capture
> + functionality. It provides multiple PWM output channels for generating
> + variable duty-cycle waveforms, and multiple input capture channels for
> + measuring external signal periods and pulse widths. PWM output channels
> + and input capture channels are configured independently via
> + st,pwm-num-chan and st,capture-num-chan respectively.
> +
> +allOf:
> + - $ref: pwm.yaml#
Where is this compatible used?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: pwm: st,pwm: convert to DT schema
2026-06-23 7:17 ` Krzysztof Kozlowski
@ 2026-06-23 14:16 ` Charan Pedumuru
2026-06-23 14:25 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Charan Pedumuru @ 2026-06-23 14:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pal Singh, linux-pwm, devicetree, linux-kernel
On 23-06-2026 12:47, Krzysztof Kozlowski wrote:
> On Thu, Jun 18, 2026 at 12:42:07PM +0000, Charan Pedumuru wrote:
>> +description:
>> + The STiH41x PWM controller supports both PWM output and input capture
>> + functionality. It provides multiple PWM output channels for generating
>> + variable duty-cycle waveforms, and multiple input capture channels for
>> + measuring external signal periods and pulse widths. PWM output channels
>> + and input capture channels are configured independently via
>> + st,pwm-num-chan and st,capture-num-chan respectively.
>> +
>> +allOf:
>> + - $ref: pwm.yaml#
>
> Where is this compatible used?
I will remove this allof and redefine the YAML again
>
> Best regards,
> Krzysztof
>
--
Best Regards,
Charan.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: pwm: st,pwm: convert to DT schema
2026-06-23 14:16 ` Charan Pedumuru
@ 2026-06-23 14:25 ` Krzysztof Kozlowski
2026-06-23 14:31 ` Charan Pedumuru
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-23 14:25 UTC (permalink / raw)
To: Charan Pedumuru
Cc: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pal Singh, linux-pwm, devicetree, linux-kernel
On 23/06/2026 16:16, Charan Pedumuru wrote:
>
>
> On 23-06-2026 12:47, Krzysztof Kozlowski wrote:
>> On Thu, Jun 18, 2026 at 12:42:07PM +0000, Charan Pedumuru wrote:
>>> +description:
>>> + The STiH41x PWM controller supports both PWM output and input capture
>>> + functionality. It provides multiple PWM output channels for generating
>>> + variable duty-cycle waveforms, and multiple input capture channels for
>>> + measuring external signal periods and pulse widths. PWM output channels
>>> + and input capture channels are configured independently via
>>> + st,pwm-num-chan and st,capture-num-chan respectively.
>>> +
>>> +allOf:
>>> + - $ref: pwm.yaml#
>>
>> Where is this compatible used?
>
> I will remove this allof and redefine the YAML again
>
Sorry, I think I messed something so comment was incorrectly placed.
The comment should be under:
"+ const: st,pwm"
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: pwm: st,pwm: convert to DT schema
2026-06-23 14:25 ` Krzysztof Kozlowski
@ 2026-06-23 14:31 ` Charan Pedumuru
0 siblings, 0 replies; 5+ messages in thread
From: Charan Pedumuru @ 2026-06-23 14:31 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pal Singh, linux-pwm, devicetree, linux-kernel
On 23-06-2026 19:55, Krzysztof Kozlowski wrote:
> On 23/06/2026 16:16, Charan Pedumuru wrote:
>>
>>
>> On 23-06-2026 12:47, Krzysztof Kozlowski wrote:
>>> On Thu, Jun 18, 2026 at 12:42:07PM +0000, Charan Pedumuru wrote:
>>>> +description:
>>>> + The STiH41x PWM controller supports both PWM output and input capture
>>>> + functionality. It provides multiple PWM output channels for generating
>>>> + variable duty-cycle waveforms, and multiple input capture channels for
>>>> + measuring external signal periods and pulse widths. PWM output channels
>>>> + and input capture channels are configured independently via
>>>> + st,pwm-num-chan and st,capture-num-chan respectively.
>>>> +
>>>> +allOf:
>>>> + - $ref: pwm.yaml#
>>>
>>> Where is this compatible used?
>>
>> I will remove this allof and redefine the YAML again
>>
>
>
> Sorry, I think I messed something so comment was incorrectly placed.
>
> The comment should be under:
>
> "+ const: st,pwm"
Okay, this compatible is not used and there is a similar compatible "st,sti-pwm", AI bot detected it and I will rename it and modify the commit message with necessary explanation. Also the maintainer email doesn't exist now. I will change that too with other maintainer. Thank you.
>
> Best regards,
> Krzysztof
--
Best Regards,
Charan.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-23 14:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-18 12:42 [PATCH v2] dt-bindings: pwm: st,pwm: convert to DT schema Charan Pedumuru
2026-06-23 7:17 ` Krzysztof Kozlowski
2026-06-23 14:16 ` Charan Pedumuru
2026-06-23 14:25 ` Krzysztof Kozlowski
2026-06-23 14:31 ` Charan Pedumuru
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome