mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andrew Paprocki" <andrew@ishiboo.com>
To: "Francois Romieu" <romieu@fr.zoreil.com>
Cc: LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Subject: Re: kernel BUG at /usr/src/linux-2.6.25/kernel/workqueue.c:224! (r8169?)
Date: Mon, 21 Apr 2008 17:22:15 -0400	[thread overview]
Message-ID: <76366b180804211422k33057607p586b5deed7849c07@mail.gmail.com> (raw)
In-Reply-To: <20080421203458.GA2931@electric-eye.fr.zoreil.com>

Francois,

On this kernel CONFIG_R8169_NAPI is disabled, so that code would not
even be compiled in. Is NAPI stable enough that I should be using it
now? (It is still marked experimental)

Thanks,
-Andrew

On Mon, Apr 21, 2008 at 4:34 PM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> Andrew Paprocki <andrew@ishiboo.com> :
>
> > I just received a similar bug on workqueue.c:223 while I was not doing
>  > anything with the card. These bugs seem to have increased with
>  > frequency when running under 2.6.25. It used to take me some time to
>  > cause a problem to appear under 2.6.24, but under 2.6.25 they appear
>  > very readily. I was actually not touching the machine at all when this
>  > appeared on the console:
>
>  Does the patch below decrease the frequency of the bug ?
>
>  diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
>  index 3acfeea..6ee9db1 100644
>  --- a/drivers/net/r8169.c
>  +++ b/drivers/net/r8169.c
>  @@ -2398,8 +2398,6 @@ static void rtl8169_wait_for_quiescence(struct net_device *dev)
>         rtl8169_irq_mask_and_ack(ioaddr);
>
>   #ifdef CONFIG_R8169_NAPI
>  -       tp->intr_mask = 0xffff;
>  -       RTL_W16(IntrMask, tp->intr_event);
>         napi_enable(&tp->napi);
>   #endif
>   }
>
>  --
>  Ueimor
>
>

  reply	other threads:[~2008-04-21 21:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-20 22:48 Andrew Paprocki
2008-04-21  3:16 ` Andrew Paprocki
2008-04-21 20:34   ` Francois Romieu
2008-04-21 21:22     ` Andrew Paprocki [this message]
2008-04-21 21:29       ` Francois Romieu
2008-04-21 21:50         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76366b180804211422k33057607p586b5deed7849c07@mail.gmail.com \
    --to=andrew@ishiboo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®