From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
Richard Gong <richard.gong@linux.intel.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Tull <atull@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Moritz Fischer <mdf@kernel.org>
Subject: Re: [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in stratix10_svc_drv_probe()
Date: Wed, 29 Apr 2020 13:51:00 +0200 [thread overview]
Message-ID: <767eb869-d9c1-757b-77a6-79927728ddcd@web.de> (raw)
> While at it, also move a 'platform_device_put()' call to the error handling path.
How do you think about to use the message “Complete exception handling
in stratix10_svc_drv_probe()” in the final commit subject?
…
> +++ b/drivers/firmware/stratix10-svc.c
…
> @@ -1043,24 +1043,34 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev)
…
> + return 0;
> +
> +put_platform:
> + platform_device_put(svc->stratix10_svc_rsu);
> +err_free_kfifo:
…
> return ret;
> }
Can the label “err_put_device” be more appropriate for the improved
function implementation?
(Or: Would you like to omit the prefix “err_” for these jump targets?)
Regards,
Markus
next reply other threads:[~2020-04-29 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 11:51 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-29 6:52 [PATCH 0/4 v2] firmware: stratix10-svc: Fix some error handling code Christophe JAILLET
2020-04-29 6:52 ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_probe()' Christophe JAILLET
2020-05-05 14:02 ` Richard Gong
2020-05-05 15:15 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=767eb869-d9c1-757b-77a6-79927728ddcd@web.de \
--to=markus.elfring@web.de \
--cc=atull@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®