* [PATCH] drivers/misc: Add NULL check in aspeed_lpc_enable_snoop
@ 2025-03-31 9:39 Henry Martin
2025-03-31 11:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Henry Martin @ 2025-03-31 9:39 UTC (permalink / raw)
To: joel, andrew
Cc: herve.codina, gsomlo, heiko, andersson, u.kleine-koenig,
bsdhenrymartin, linux-arm-kernel, linux-aspeed, linux-kernel
When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function aspeed_lpc_enable_snoop.
A NULL check should be added after the devm_kasprintf() to prevent potential NULL pointer dereference error.
Fixes: 3772e5da44542 ("Aspeed LPC snoop output using misc chardev")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
---
drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
index 9ab5ba9cf1d6..376b3a910797 100644
--- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
+++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -200,6 +200,8 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
lpc_snoop->chan[channel].miscdev.minor = MISC_DYNAMIC_MINOR;
lpc_snoop->chan[channel].miscdev.name =
devm_kasprintf(dev, GFP_KERNEL, "%s%d", DEVICE_NAME, channel);
+ if (!lpc_snoop->chan[channel].miscdev.name)
+ return -ENOMEM;
lpc_snoop->chan[channel].miscdev.fops = &snoop_fops;
lpc_snoop->chan[channel].miscdev.parent = dev;
rc = misc_register(&lpc_snoop->chan[channel].miscdev);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/misc: Add NULL check in aspeed_lpc_enable_snoop
2025-03-31 9:39 [PATCH] drivers/misc: Add NULL check in aspeed_lpc_enable_snoop Henry Martin
@ 2025-03-31 11:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-31 11:40 UTC (permalink / raw)
To: Henry Martin, joel, andrew
Cc: herve.codina, gsomlo, heiko, andersson, u.kleine-koenig,
linux-arm-kernel, linux-aspeed, linux-kernel
On 31/03/2025 11:39, Henry Martin wrote:
> When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function aspeed_lpc_enable_snoop.
>
> A NULL check should be added after the devm_kasprintf() to prevent potential NULL pointer dereference error.
>
Same comments.
> Fixes: 3772e5da44542 ("Aspeed LPC snoop output using misc chardev")
>
There is never a blank line between tags.
> Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
> ---
> drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
> index 9ab5ba9cf1d6..376b3a910797 100644
> --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
> +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
> @@ -200,6 +200,8 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
> lpc_snoop->chan[channel].miscdev.minor = MISC_DYNAMIC_MINOR;
> lpc_snoop->chan[channel].miscdev.name =
> devm_kasprintf(dev, GFP_KERNEL, "%s%d", DEVICE_NAME, channel);
> + if (!lpc_snoop->chan[channel].miscdev.name)
> + return -ENOMEM;
Missing cleanup.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-31 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-31 9:39 [PATCH] drivers/misc: Add NULL check in aspeed_lpc_enable_snoop Henry Martin
2025-03-31 11:40 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®