mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH 3/9] memory: samsung: exynos5422-dmc: use scoped device node handling to simplify error paths
Date: Wed, 14 Aug 2024 19:57:18 +0200	[thread overview]
Message-ID: <768894bb-a12a-4919-9b4d-b579c153a556@linaro.org> (raw)
In-Reply-To: <20240814174246.00007e4e@Huawei.com>

On 14/08/2024 18:42, Jonathan Cameron wrote:
> On Mon, 12 Aug 2024 15:33:57 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
>> Obtain the device node reference with scoped/cleanup.h to reduce error
>> handling and make the code a bit simpler.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Trivial comments inline
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
>> ---
>>  drivers/memory/samsung/exynos5422-dmc.c | 31 +++++++++++--------------------
>>  1 file changed, 11 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
>> index da7ecd921c72..d3ae4d95a3ba 100644
>> --- a/drivers/memory/samsung/exynos5422-dmc.c
>> +++ b/drivers/memory/samsung/exynos5422-dmc.c
>> @@ -4,6 +4,7 @@
>>   * Author: Lukasz Luba <l.luba@partner.samsung.com>
>>   */
>>  
>> +#include <linux/cleanup.h>
>>  #include <linux/clk.h>
>>  #include <linux/devfreq.h>
>>  #include <linux/devfreq-event.h>
>> @@ -1176,10 +1177,10 @@ static int of_get_dram_timings(struct exynos5_dmc *dmc)
>>  {
>>  	int ret = 0;
>>  	int idx;
>> -	struct device_node *np_ddr;
> 
> This would definitely benefit from a
> struct device *dev = dmc->dev;

True, I'll do it in separate patch.

> 
>>  	u32 freq_mhz, clk_period_ps;
>>  
>> -	np_ddr = of_parse_phandle(dmc->dev->of_node, "device-handle", 0);
>> +	struct device_node *np_ddr __free(device_node) = of_parse_phandle(dmc->dev->of_node,
>> +									  "device-handle", 0);
> Trivial. Maybe consider the wrap suggested in patch 1.
>> +	struct device_node *np_ddr __free(device_node) =
> 		of_parse_phandle(dmc->dev->of_node, "device-handle", 0);

Ack.



Best regards,
Krzysztof


  reply	other threads:[~2024-08-14 17:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 13:33 [PATCH 0/9] memory: simplify with scoped/cleanup.h for device nodes Krzysztof Kozlowski
2024-08-12 13:33 ` [PATCH 1/9] memory: atmel-ebi: use scoped device node handling to simplify error paths Krzysztof Kozlowski
2024-08-14 16:38   ` Jonathan Cameron
2024-08-14 17:56     ` Krzysztof Kozlowski
2024-08-12 13:33 ` [PATCH 2/9] memory: atmel-ebi: simplify with scoped for each OF child loop Krzysztof Kozlowski
2024-08-14 16:39   ` Jonathan Cameron
2024-08-12 13:33 ` [PATCH 3/9] memory: samsung: exynos5422-dmc: use scoped device node handling to simplify error paths Krzysztof Kozlowski
2024-08-14 16:42   ` Jonathan Cameron
2024-08-14 17:57     ` Krzysztof Kozlowski [this message]
2024-08-12 13:33 ` [PATCH 4/9] memory: stm32-fmc2-ebi: simplify with scoped for each OF child loop Krzysztof Kozlowski
2024-08-14 16:45   ` Jonathan Cameron
2024-08-14 17:59     ` Krzysztof Kozlowski
2024-08-12 13:33 ` [PATCH 5/9] memory: tegra-mc: " Krzysztof Kozlowski
2024-08-14 16:50   ` Jonathan Cameron
2024-08-12 13:34 ` [PATCH 6/9] memory: tegra124-emc: " Krzysztof Kozlowski
2024-08-14 16:51   ` Jonathan Cameron
2024-08-12 13:34 ` [PATCH 7/9] memory: tegra20-emc: " Krzysztof Kozlowski
2024-08-14 16:52   ` Jonathan Cameron
2024-08-12 13:34 ` [PATCH 8/9] memory: tegra30-emc: " Krzysztof Kozlowski
2024-08-12 13:34 ` [PATCH 9/9] memory: ti-aemif: " Krzysztof Kozlowski
2024-08-14 16:55   ` Jonathan Cameron
2024-08-14 18:01     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=768894bb-a12a-4919-9b4d-b579c153a556@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alim.akhtar@samsung.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=ssantosh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®