mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Mike Christie <michael.christie@oracle.com>,
	Wenchao Hao <haowenchao@huawei.com>,
	Steffen Maier <maier@linux.ibm.com>,
	linux-scsi@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Lee Duncan <lduncan@suse.com>, John Garry <john.garry@huawei.com>
Cc: Wu Bo <wubo40@huawei.com>, Feilong Lin <linfeilong@huawei.com>,
	zhangjian013@huawei.com
Subject: Re: [REQUEST DISCUSS]: speed up SCSI error handle for host with massive devices
Date: Mon, 4 Apr 2022 07:28:00 +0200	[thread overview]
Message-ID: <769bcd36-4818-8470-2daa-49ac5c05b33a@suse.de> (raw)
In-Reply-To: <84b38f16-2a32-f361-43e5-34bce1012e71@oracle.com>

On 4/3/22 19:17, Mike Christie wrote:
> On 4/3/22 12:14 PM, Mike Christie wrote:
>> We could share code with scsi_ioctl_reset as well. Drivers that support
>> TMFs via that ioctl already expect queuecommand to be possibly in the
>> middle of a run and IO not yet timed out. For example, the code to
>> block a queue and reset the device could be used for the new EH and
>> SG_SCSI_RESET_DEVICE handling.
>>
> 
> Hannes or others,
> 
> How do parallel SCSI drivers support scsi_ioctl_reset? Is is not fully
> supported and more only used for controlled testing?

That's actually a problem in scsi_ioctl_reset(); it really should wait 
for all I/O to quiesce. Currently it just sets the 'tmf' flag and calls 
into the various reset functions.

But really, I'd rather get my EH rework in before we're start discussing 
modifying EH behaviour.
Let me repost it ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

  reply	other threads:[~2022-04-04  5:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  9:06 Wenchao Hao
2022-03-29 10:56 ` Steffen Maier
2022-03-29 12:40   ` Wenchao Hao
2022-03-29 18:56     ` Hannes Reinecke
2022-03-30  9:11       ` Wenchao Hao
2022-03-30  9:32         ` Hannes Reinecke
2022-03-30 10:59           ` Wenchao Hao
2022-04-03 17:14             ` Mike Christie
2022-04-03 17:17               ` Mike Christie
2022-04-04  5:28                 ` Hannes Reinecke [this message]
2022-04-04  7:40                   ` Christoph Hellwig
2022-04-06  9:40                   ` Wenchao Hao
2023-10-12 14:50                     ` Hannes Reinecke
2023-10-12 16:09                       ` Wenchao Hao
2022-04-06 10:32                   ` Wenchao Hao
2022-04-06  9:40               ` Wenchao Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=769bcd36-4818-8470-2daa-49ac5c05b33a@suse.de \
    --to=hare@suse.de \
    --cc=haowenchao@huawei.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=lduncan@suse.com \
    --cc=linfeilong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=maier@linux.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=wubo40@huawei.com \
    --cc=zhangjian013@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®