From: Jens Axboe <axboe@kernel.dk>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Christoph Hellwig <hch@lst.de>,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v4 0/3] random: convert to using iters, for Al Viro
Date: Fri, 20 May 2022 10:00:40 -0600 [thread overview]
Message-ID: <76a601c2-a32d-1c28-3a9c-f645e57e3af1@kernel.dk> (raw)
In-Reply-To: <Yoe6iltcPVcTL6dD@zx2c4.com>
On 5/20/22 9:58 AM, Jason A. Donenfeld wrote:
> Hi Jens,
>
> On Fri, May 20, 2022 at 09:51:06AM -0600, Jens Axboe wrote:
>> ABI. Obviously that can happen sometimes, but I think this one is
>> exactly the poster child of breakage that should NOT happen. We took
>> away a feature that someone depended on.
>
> I suppose somebody (Meta, I presume) *did* notice the breakage, which is
> sign enough.
Indeed, this is how I found out. And then you have to wonder how often
this has happened elsewhere where nobody bothered to report it, or how
many are still waiting to happen because they are still on an older
kernel and just haven't upgraded yet. Or upgraded and rolled back
perhaps.
None of the latter really matters, it's eventual breakage there, and
very real breakage right now for the first case.
--
Jens Axboe
next prev parent reply other threads:[~2022-05-20 16:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 9:44 Jason A. Donenfeld
2022-05-20 9:44 ` [PATCH v4 1/3] random: convert to using fops->read_iter() Jason A. Donenfeld
2022-05-20 13:37 ` Jason A. Donenfeld
2022-05-20 14:36 ` Jens Axboe
2022-05-20 14:39 ` Jason A. Donenfeld
2022-05-20 15:12 ` Al Viro
2022-05-20 9:44 ` [PATCH v4 2/3] random: convert to using fops->write_iter() Jason A. Donenfeld
2022-05-20 9:44 ` [PATCH v4 3/3] random: wire up fops->splice_{read,write}_iter() Jason A. Donenfeld
2022-05-20 12:16 ` [PATCH v4 0/3] random: convert to using iters, for Al Viro Jens Axboe
2022-05-20 15:25 ` Jason A. Donenfeld
2022-05-20 15:34 ` Jens Axboe
2022-05-20 15:39 ` Jason A. Donenfeld
2022-05-20 15:44 ` Jens Axboe
2022-05-20 15:55 ` Jason A. Donenfeld
2022-05-20 15:58 ` Jens Axboe
2022-05-20 16:03 ` Jason A. Donenfeld
2022-05-20 16:06 ` Jens Axboe
2022-05-20 15:46 ` Jason A. Donenfeld
2022-05-20 15:51 ` Jens Axboe
2022-05-20 15:58 ` Jason A. Donenfeld
2022-05-20 16:00 ` Jens Axboe [this message]
2022-05-20 15:47 ` Al Viro
2022-05-20 15:53 ` Jens Axboe
2022-05-20 16:15 ` Al Viro
2022-05-20 16:24 ` Jens Axboe
2022-05-20 16:39 ` Jason A. Donenfeld
2022-05-20 16:41 ` Jens Axboe
2022-05-24 4:52 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76a601c2-a32d-1c28-3a9c-f645e57e3af1@kernel.dk \
--to=axboe@kernel.dk \
--cc=Jason@zx2c4.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®