mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Stanner <phasta@mailbox.org>
To: "Yujie Liu" <yujie.liu@intel.com>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	"Alex Deucher" <Alexander.Deucher@amd.com>,
	"Philipp Stanner" <phasta@kernel.org>,
	amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drm/scheduler: fix kernel-doc warning for drm_sched_job_done()
Date: Wed, 04 Mar 2026 10:34:48 +0100	[thread overview]
Message-ID: <76e69151fe679658d8816dcce1011cea20633252.camel@mailbox.org> (raw)
In-Reply-To: <20260227082452.1802922-1-yujie.liu@intel.com>

On Fri, 2026-02-27 at 16:24 +0800, Yujie Liu wrote:
> Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'result' not described in 'drm_sched_job_done'
> 
> Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>

Pushed to drm-misc-fixes.

Thank you

P.

PS:
for the future, scripts/get_maintainer provides a list of all recipents
a patch should go to (two maintainers were missing). And a sentence or
two in commit messages to describe what is being done are desirable. I
added them for now, so no big deal. Just as a tip for the future :]

> ---
> Changes in v2:
> - Split from the original patch set
>   https://lore.kernel.org/all/20260226030038.1182961-1-yujie.liu@intel.com/
> - Rebase onto latest drm-tip
> 
> Changes in v3:
> - Change "errno" to uppercase "ERRNO" (suggested by Philipp)
> 
>  drivers/gpu/drm/scheduler/sched_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index e6ee35406165..2d5cb21a05b6 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched)
>  /**
>   * drm_sched_job_done - complete a job
>   * @s_job: pointer to the job which is done
> + * @result: 0 on success, -ERRNO on error
>   *
>   * Finish the job's fence and resubmit the work items.
>   */


  reply	other threads:[~2026-03-04  9:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27  8:24 Yujie Liu
2026-03-04  9:34 ` Philipp Stanner [this message]
2026-03-05  5:47   ` Yujie Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76e69151fe679658d8816dcce1011cea20633252.camel@mailbox.org \
    --to=phasta@mailbox.org \
    --cc=Alexander.Deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phasta@kernel.org \
    --cc=yujie.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®