* [PATCH] net: wireless: cisco: Fix possible uninit bug
@ 2023-07-04 23:50 Yu Hao
2023-07-06 7:53 ` Paolo Abeni
0 siblings, 1 reply; 5+ messages in thread
From: Yu Hao @ 2023-07-04 23:50 UTC (permalink / raw)
To: kvalo, keescook, gustavoars, Jason, linux-wireless, linux-kernel
The struct cap_rid should be initialized by function readCapabilityRid.
However, there is not return value check. Iit is possible that
the function readCapabilityRid returns error code and cap_rid.softCap
is not initialized. But there is a read later for this field.
Signed-off-by: Yu Hao <yhao016@ucr.edu>
---
drivers/net/wireless/cisco/airo.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/cisco/airo.c
b/drivers/net/wireless/cisco/airo.c
index 7c4cc5f5e1eb..b3736d76a5d5 100644
--- a/drivers/net/wireless/cisco/airo.c
+++ b/drivers/net/wireless/cisco/airo.c
@@ -6950,8 +6950,11 @@ static int airo_get_range(struct net_device *dev,
CapabilityRid cap_rid; /* Card capability info */
int i;
int k;
+ int status;
- readCapabilityRid(local, &cap_rid, 1);
+ status = readCapabilityRid(local, &cap_rid, 1);
+ if (status != SUCCESS)
+ return ERROR;
dwrq->length = sizeof(struct iw_range);
memset(range, 0, sizeof(*range));
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: wireless: cisco: Fix possible uninit bug
2023-07-04 23:50 [PATCH] net: wireless: cisco: Fix possible uninit bug Yu Hao
@ 2023-07-06 7:53 ` Paolo Abeni
2023-07-10 2:52 ` Yu Hao
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Abeni @ 2023-07-06 7:53 UTC (permalink / raw)
To: Yu Hao, kvalo, keescook, gustavoars, Jason, linux-wireless, linux-kernel
On Tue, 2023-07-04 at 16:50 -0700, Yu Hao wrote:
> The struct cap_rid should be initialized by function readCapabilityRid.
> However, there is not return value check. Iit is possible that
> the function readCapabilityRid returns error code and cap_rid.softCap
> is not initialized. But there is a read later for this field.
>
> Signed-off-by: Yu Hao <yhao016@ucr.edu>
> ---
> drivers/net/wireless/cisco/airo.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cisco/airo.c
> b/drivers/net/wireless/cisco/airo.c
> index 7c4cc5f5e1eb..b3736d76a5d5 100644
> --- a/drivers/net/wireless/cisco/airo.c
> +++ b/drivers/net/wireless/cisco/airo.c
> @@ -6950,8 +6950,11 @@ static int airo_get_range(struct net_device *dev,
> CapabilityRid cap_rid; /* Card capability info */
> int i;
> int k;
> + int status;
>
> - readCapabilityRid(local, &cap_rid, 1);
> + status = readCapabilityRid(local, &cap_rid, 1);
> + if (status != SUCCESS)
> + return ERROR;
This value is returned directly to the network stack, you must use a
standard error code instead (e.g. -EINVAL).
Also, please add a suitable 'Fixes' tag, thanks!
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: wireless: cisco: Fix possible uninit bug
2023-07-06 7:53 ` Paolo Abeni
@ 2023-07-10 2:52 ` Yu Hao
2023-07-10 16:19 ` Paolo Abeni
0 siblings, 1 reply; 5+ messages in thread
From: Yu Hao @ 2023-07-10 2:52 UTC (permalink / raw)
To: Paolo Abeni
Cc: kvalo, keescook, gustavoars, Jason, linux-wireless, linux-kernel
Sure.
I found that the related code is from Linux-2.6.12-rc2.
In this situation, the 'Fixes' tag should be 'Fixes: 1da177e4c3f4
("Linux-2.6.12-rc2")'?
Yu Hao
On Thu, Jul 6, 2023 at 12:54 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> On Tue, 2023-07-04 at 16:50 -0700, Yu Hao wrote:
> > The struct cap_rid should be initialized by function readCapabilityRid.
> > However, there is not return value check. Iit is possible that
> > the function readCapabilityRid returns error code and cap_rid.softCap
> > is not initialized. But there is a read later for this field.
> >
> > Signed-off-by: Yu Hao <yhao016@ucr.edu>
> > ---
> > drivers/net/wireless/cisco/airo.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/cisco/airo.c
> > b/drivers/net/wireless/cisco/airo.c
> > index 7c4cc5f5e1eb..b3736d76a5d5 100644
> > --- a/drivers/net/wireless/cisco/airo.c
> > +++ b/drivers/net/wireless/cisco/airo.c
> > @@ -6950,8 +6950,11 @@ static int airo_get_range(struct net_device *dev,
> > CapabilityRid cap_rid; /* Card capability info */
> > int i;
> > int k;
> > + int status;
> >
> > - readCapabilityRid(local, &cap_rid, 1);
> > + status = readCapabilityRid(local, &cap_rid, 1);
> > + if (status != SUCCESS)
> > + return ERROR;
>
> This value is returned directly to the network stack, you must use a
> standard error code instead (e.g. -EINVAL).
>
> Also, please add a suitable 'Fixes' tag, thanks!
>
> Paolo
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: wireless: cisco: Fix possible uninit bug
2023-07-10 2:52 ` Yu Hao
@ 2023-07-10 16:19 ` Paolo Abeni
2023-07-11 5:17 ` Yu Hao
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Abeni @ 2023-07-10 16:19 UTC (permalink / raw)
To: Yu Hao; +Cc: kvalo, keescook, gustavoars, Jason, linux-wireless, linux-kernel
On Sun, 2023-07-09 at 19:52 -0700, Yu Hao wrote:
> I found that the related code is from Linux-2.6.12-rc2.
> In this situation, the 'Fixes' tag should be 'Fixes: 1da177e4c3f4
> ("Linux-2.6.12-rc2")'?
Exactly!
Cheers,
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: wireless: cisco: Fix possible uninit bug
2023-07-10 16:19 ` Paolo Abeni
@ 2023-07-11 5:17 ` Yu Hao
0 siblings, 0 replies; 5+ messages in thread
From: Yu Hao @ 2023-07-11 5:17 UTC (permalink / raw)
To: Paolo Abeni
Cc: kvalo, keescook, gustavoars, Jason, linux-wireless, linux-kernel
Got it. Let me do this.
Yu Hao
On Mon, Jul 10, 2023 at 9:20 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> On Sun, 2023-07-09 at 19:52 -0700, Yu Hao wrote:
> > I found that the related code is from Linux-2.6.12-rc2.
> > In this situation, the 'Fixes' tag should be 'Fixes: 1da177e4c3f4
> > ("Linux-2.6.12-rc2")'?
>
> Exactly!
>
> Cheers,
>
> Paolo
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-11 5:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-04 23:50 [PATCH] net: wireless: cisco: Fix possible uninit bug Yu Hao
2023-07-06 7:53 ` Paolo Abeni
2023-07-10 2:52 ` Yu Hao
2023-07-10 16:19 ` Paolo Abeni
2023-07-11 5:17 ` Yu Hao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®