mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
To: Sumit Gupta <sumitg@nvidia.com>,
	rafael@kernel.org, viresh.kumar@linaro.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, treding@nvidia.com,
	jonathanh@nvidia.com, linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: bbasu@nvidia.com, Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Subject: Re: [PATCH v2 0/9] cpufreq: tegra194: add Tegra264 support
Date: Wed, 18 Nov 2026 11:55:36 +0800	[thread overview]
Message-ID: <77166c44-71fa-4e28-9399-3f7c4b8b999b@oss.qualcomm.com> (raw)
In-Reply-To: <20261117154954.625126-1-sumitg@nvidia.com>

On 11/17/2026 11:49 PM, Sumit Gupta wrote:
> This series adds cpufreq support for Tegra264, which joins the SoCs
> already supported by the tegra194-cpufreq driver.
> 
> Tegra264 keeps the existing model, where BPMP provides the NDIV limits.
> The driver derives the current frequency from the core clock and
> reference counters.
> 
> The main differences are:
>   - Frequency read: through system registers, as on Tegra194, but from
>     the 64-bit architected AMU counters. The reference counter ticks at
>     the system counter rate (CNTFRQ).


Hi Sumit,

Thanks for the update. All my v1 comments are addressed.

For patches 1-7 and 9:

Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>

I left one comment on patch 8: the two AMU counters (core and constant)
are read separately in a kworker with interrupts enabled, so an
interrupt or preemption between the reads can skew the computed
frequency. Please have a look.


-- 
Thx and BRs,
Zhongqiu Han

      parent reply	other threads:[~2026-11-18  3:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 15:49 Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 1/9] cpufreq: tegra194: move MPIDR read to CPU hotplug callback Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 2/9] cpufreq: tegra194: remove duplicate counter sampling loops Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 3/9] cpufreq: tegra194: add tegra_counter_delta helper Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 4/9] cpufreq: tegra194: add per-SoC counter mask Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 5/9] cpufreq: tegra194: split MMIO mapping from ACTMON offset Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 6/9] dt-bindings: arm: nvidia: Document the Tegra264 CCPLEX cluster Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 7/9] cpufreq: tegra194: derive frequency domain from device tree Sumit Gupta
2026-11-17 15:49 ` [PATCH v2 8/9] cpufreq: tegra194: Add support for Tegra264 Sumit Gupta
2026-11-18  3:47   ` Zhongqiu Han
2026-11-17 15:49 ` [PATCH v2 9/9] arm64: tegra: Add CCPLEX cluster node " Sumit Gupta
2026-11-18  3:55 ` Zhongqiu Han [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77166c44-71fa-4e28-9399-3f7c4b8b999b@oss.qualcomm.com \
    --to=zhongqiu.han@oss.qualcomm.com \
    --cc=bbasu@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sumitg@nvidia.com \
    --cc=treding@nvidia.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®