From: Arnd Bergmann <arnd@arndb.de>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Eric Andersson <eric.andersson@unixphere.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] misc/bmp085: Enable building as a module
Date: Mon, 14 Dec 2015 23:23:45 +0100 [thread overview]
Message-ID: <7776312.pmJpCBty6D@wuerfel> (raw)
In-Reply-To: <20151214142922.GM28542@decadent.org.uk>
On Monday 14 December 2015 14:29:23 Ben Hutchings wrote:
> Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
> driver' changed the BMP085 config symbol to a boolean. I see no
> reason why the shared code cannot be built as a module, so change it
> back to tristate.
>
> Fixes: 985087dbcb02 ("misc: add support for bmp18x chips to the bmp085 driver")
> Cc: Eric Andersson <eric.andersson@unixphere.com>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>
Looks good to me. There are often subtle bugs in configurations like these
where a driver can depend on either SPI or I2C, but I don't see a problem
here, because the common code still only gets built as a module if neither
front-end is built-in.
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2015-12-14 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 14:29 Ben Hutchings
2015-12-14 22:23 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7776312.pmJpCBty6D@wuerfel \
--to=arnd@arndb.de \
--cc=ben@decadent.org.uk \
--cc=eric.andersson@unixphere.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome