mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Arnd Bergmann <arnd@arndb.de>, Steve French <sfrench@samba.org>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	linux-kernel@vger.kernel.org,
	Pavel Shilovsky <pshilov@microsoft.com>,
	Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m
Date: Tue, 19 Dec 2017 11:33:15 +0100	[thread overview]
Message-ID: <77af1425-2d5a-8482-fa39-c83d2056eaa4@samba.org> (raw)
In-Reply-To: <20171219101327.2165797-1-arnd@arndb.de>


[-- Attachment #1.1: Type: text/plain, Size: 726 bytes --]

Hi Arnd,

> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
> index 500fd69fb58b..3bfc55c08bef 100644
> --- a/fs/cifs/Kconfig
> +++ b/fs/cifs/Kconfig
> @@ -199,6 +199,7 @@ config CIFS_SMB311
>  config CIFS_SMB_DIRECT
>  	bool "SMB Direct support (Experimental)"
>  	depends on CIFS && INFINIBAND
> +	depends on CIFS=m || INFINIBAND=y
>  	help
>  	  Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
>  	  SMB Direct allows transferring SMB packets over RDMA. If unsure,

Is this really correct? Should CIFS_SMB_DIRECT be allowed with:

CIFS=n and INFINIBAND=y ???
or
CIFS=m and INFINIBAND=n ???

I guess a more complex logic should be used here
or am I missing something?

metze



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2017-12-19 10:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 10:12 Arnd Bergmann
2017-12-19 10:33 ` Stefan Metzmacher [this message]
2017-12-19 10:56   ` Arnd Bergmann
2017-12-19 11:01     ` Stefan Metzmacher
2017-12-19 12:39 ` Jean Delvare
2017-12-19 21:21 ` Long Li
2017-12-20  6:34   ` Stefan Metzmacher
2017-12-20  8:17   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77af1425-2d5a-8482-fa39-c83d2056eaa4@samba.org \
    --to=metze@samba.org \
    --cc=arnd@arndb.de \
    --cc=jdelvare@suse.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pshilov@microsoft.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®