From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment
Date: Tue, 4 Jun 2024 15:18:55 +0200 [thread overview]
Message-ID: <77b4e4ad-2b1e-4b6d-bc3b-0c7b339bc295@linaro.org> (raw)
In-Reply-To: <20240527144700.GC713992@gnbcxd0016.gnb.st.com>
On 27/05/2024 16:47, Alain Volmat wrote:
> Hi Krzysztof,
>
> thanks for your patch, sorry for the delay.
>
> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
>> Core in platform_driver_register() already sets the .owner, so driver
>> does not need to. Whatever is set here will be anyway overwritten by
>> main driver calling platform_driver_register().
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>
>> I forgot two drivers.
>> drivers/gpu/drm/sti/sti_hdmi.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
>> index 500936d5743c..b0d84440a87b 100644
>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>> struct platform_driver sti_hdmi_driver = {
>> .driver = {
>> .name = "sti-hdmi",
>> - .owner = THIS_MODULE,
>> .of_match_table = hdmi_of_match,
>> },
>> .probe = sti_hdmi_probe,
>> --
>> 2.34.1
>>
>
> Acked-by: Alain Volmat <alain.volmat@foss.st.com>
What does this ack mean? You are the maintainer, so what is supposed to
happen now? If maintainer does not take patches, then the DRM STI looks
orphaned.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-04 13:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 20:38 [PATCH 1/4] drm/sti: dvo: " Krzysztof Kozlowski
2024-03-30 20:38 ` [PATCH 2/4] drm/sti: hda: " Krzysztof Kozlowski
2024-05-27 14:41 ` Alain Volmat
2024-03-30 20:38 ` [PATCH 3/4] drm/sti: tvout: " Krzysztof Kozlowski
2024-05-27 14:46 ` Alain Volmat
2024-03-30 20:38 ` [PATCH 4/4] drm/sti: vtg: " Krzysztof Kozlowski
2024-05-27 14:46 ` Alain Volmat
2024-03-30 20:57 ` [PATCH 5/6] drm/sti: hdmi: " Krzysztof Kozlowski
2024-03-30 20:57 ` [PATCH 6/6] drm/sti: hqvdp: " Krzysztof Kozlowski
2024-05-27 14:47 ` Alain Volmat
2024-05-27 14:47 ` [PATCH 5/6] drm/sti: hdmi: " Alain Volmat
2024-06-04 13:18 ` Krzysztof Kozlowski [this message]
2024-07-05 9:59 ` Krzysztof Kozlowski
2024-07-05 10:04 ` Neil Armstrong
2024-07-05 10:37 ` Dmitry Baryshkov
2024-07-05 11:04 ` Krzysztof Kozlowski
2024-07-05 11:14 ` Maxime Ripard
2024-07-05 11:36 ` Krzysztof Kozlowski
2024-04-24 6:38 ` [PATCH 1/4] drm/sti: dvo: " Krzysztof Kozlowski
2024-05-27 14:40 ` Alain Volmat
2024-07-05 11:21 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77b4e4ad-2b1e-4b6d-bc3b-0c7b339bc295@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®