[PATCH 1/4] drm/sti: dvo: drop driver owner assignment

[PATCH 1/4] drm/sti: dvo: drop driver owner assignment

[Krzysztof Kozlowski]

Core in platform_driver_register() already sets the .owner, so driver
does not need to.  Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpu/drm/sti/sti_dvo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index fd1df4ce3852..00502889c7f4 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -581,7 +581,6 @@ MODULE_DEVICE_TABLE(of, dvo_of_match);
 struct platform_driver sti_dvo_driver = {
 	.driver = {
 		.name = "sti-dvo",
-		.owner = THIS_MODULE,
 		.of_match_table = dvo_of_match,
 	},
 	.probe = sti_dvo_probe,
-- 
2.34.1

[PATCH 2/4] drm/sti: hda: drop driver owner assignment

[Krzysztof Kozlowski]

Core in platform_driver_register() already sets the .owner, so driver
does not need to.  Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpu/drm/sti/sti_hda.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index 6ee35612a14e..f18faad974aa 100644
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -807,7 +807,6 @@ MODULE_DEVICE_TABLE(of, hda_of_match);
 struct platform_driver sti_hda_driver = {
 	.driver = {
 		.name = "sti-hda",
-		.owner = THIS_MODULE,
 		.of_match_table = hda_of_match,
 	},
 	.probe = sti_hda_probe,
-- 
2.34.1

Re: [PATCH 2/4] drm/sti: hda: drop driver owner assignment

[Alain Volmat]

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:29PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpu/drm/sti/sti_hda.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
> index 6ee35612a14e..f18faad974aa 100644
> --- a/drivers/gpu/drm/sti/sti_hda.c
> +++ b/drivers/gpu/drm/sti/sti_hda.c
> @@ -807,7 +807,6 @@ MODULE_DEVICE_TABLE(of, hda_of_match);
>  struct platform_driver sti_hda_driver = {
>  	.driver = {
>  		.name = "sti-hda",
> -		.owner = THIS_MODULE,
>  		.of_match_table = hda_of_match,
>  	},
>  	.probe = sti_hda_probe,
> -- 
> 2.34.1
> 

Acked-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

[PATCH 3/4] drm/sti: tvout: drop driver owner assignment

[Krzysztof Kozlowski]

Core in platform_driver_register() already sets the .owner, so driver
does not need to.  Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpu/drm/sti/sti_tvout.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index 64615638b79a..e714c232026c 100644
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -886,7 +886,6 @@ MODULE_DEVICE_TABLE(of, tvout_of_match);
 struct platform_driver sti_tvout_driver = {
 	.driver = {
 		.name = "sti-tvout",
-		.owner = THIS_MODULE,
 		.of_match_table = tvout_of_match,
 	},
 	.probe = sti_tvout_probe,
-- 
2.34.1

Re: [PATCH 3/4] drm/sti: tvout: drop driver owner assignment

[Alain Volmat]

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:30PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpu/drm/sti/sti_tvout.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> index 64615638b79a..e714c232026c 100644
> --- a/drivers/gpu/drm/sti/sti_tvout.c
> +++ b/drivers/gpu/drm/sti/sti_tvout.c
> @@ -886,7 +886,6 @@ MODULE_DEVICE_TABLE(of, tvout_of_match);
>  struct platform_driver sti_tvout_driver = {
>  	.driver = {
>  		.name = "sti-tvout",
> -		.owner = THIS_MODULE,
>  		.of_match_table = tvout_of_match,
>  	},
>  	.probe = sti_tvout_probe,
> -- 
> 2.34.1
> 
Acked-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

[PATCH 4/4] drm/sti: vtg: drop driver owner assignment

[Krzysztof Kozlowski]

Core in platform_driver_register() already sets the .owner, so driver
does not need to.  Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpu/drm/sti/sti_vtg.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
index 5e5f82b6a5d9..5ba469b711b5 100644
--- a/drivers/gpu/drm/sti/sti_vtg.c
+++ b/drivers/gpu/drm/sti/sti_vtg.c
@@ -431,7 +431,6 @@ MODULE_DEVICE_TABLE(of, vtg_of_match);
 struct platform_driver sti_vtg_driver = {
 	.driver = {
 		.name = "sti-vtg",
-		.owner = THIS_MODULE,
 		.of_match_table = vtg_of_match,
 	},
 	.probe	= vtg_probe,
-- 
2.34.1

Re: [PATCH 4/4] drm/sti: vtg: drop driver owner assignment

[Alain Volmat]

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:31PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpu/drm/sti/sti_vtg.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index 5e5f82b6a5d9..5ba469b711b5 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -431,7 +431,6 @@ MODULE_DEVICE_TABLE(of, vtg_of_match);
>  struct platform_driver sti_vtg_driver = {
>  	.driver = {
>  		.name = "sti-vtg",
> -		.owner = THIS_MODULE,
>  		.of_match_table = vtg_of_match,
>  	},
>  	.probe	= vtg_probe,
> -- 
> 2.34.1
> 
Acked-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

[PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Krzysztof Kozlowski]

Core in platform_driver_register() already sets the .owner, so driver
does not need to.  Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

I forgot two drivers.
 drivers/gpu/drm/sti/sti_hdmi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index 500936d5743c..b0d84440a87b 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
 struct platform_driver sti_hdmi_driver = {
 	.driver = {
 		.name = "sti-hdmi",
-		.owner = THIS_MODULE,
 		.of_match_table = hdmi_of_match,
 	},
 	.probe = sti_hdmi_probe,
-- 
2.34.1

[PATCH 6/6] drm/sti: hqvdp: drop driver owner assignment

[Krzysztof Kozlowski]

Core in platform_driver_register() already sets the .owner, so driver
does not need to.  Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpu/drm/sti/sti_hqvdp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 0fb48ac044d8..acbf70b95aeb 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -1414,7 +1414,6 @@ MODULE_DEVICE_TABLE(of, hqvdp_of_match);
 struct platform_driver sti_hqvdp_driver = {
 	.driver = {
 		.name = "sti-hqvdp",
-		.owner = THIS_MODULE,
 		.of_match_table = hqvdp_of_match,
 	},
 	.probe = sti_hqvdp_probe,
-- 
2.34.1

Re: [PATCH 6/6] drm/sti: hqvdp: drop driver owner assignment

[Alain Volmat]

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:57:22PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpu/drm/sti/sti_hqvdp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 0fb48ac044d8..acbf70b95aeb 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1414,7 +1414,6 @@ MODULE_DEVICE_TABLE(of, hqvdp_of_match);
>  struct platform_driver sti_hqvdp_driver = {
>  	.driver = {
>  		.name = "sti-hqvdp",
> -		.owner = THIS_MODULE,
>  		.of_match_table = hqvdp_of_match,
>  	},
>  	.probe = sti_hqvdp_probe,
> -- 
> 2.34.1
> 
Acked-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Alain Volmat]

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 
> I forgot two drivers.
>  drivers/gpu/drm/sti/sti_hdmi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index 500936d5743c..b0d84440a87b 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>  struct platform_driver sti_hdmi_driver = {
>  	.driver = {
>  		.name = "sti-hdmi",
> -		.owner = THIS_MODULE,
>  		.of_match_table = hdmi_of_match,
>  	},
>  	.probe = sti_hdmi_probe,
> -- 
> 2.34.1
> 

Acked-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Krzysztof Kozlowski]

On 27/05/2024 16:47, Alain Volmat wrote:
> Hi Krzysztof,
> 
> thanks for your patch, sorry for the delay.
> 
> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
>> Core in platform_driver_register() already sets the .owner, so driver
>> does not need to.  Whatever is set here will be anyway overwritten by
>> main driver calling platform_driver_register().
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>
>> I forgot two drivers.
>>  drivers/gpu/drm/sti/sti_hdmi.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
>> index 500936d5743c..b0d84440a87b 100644
>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>>  struct platform_driver sti_hdmi_driver = {
>>  	.driver = {
>>  		.name = "sti-hdmi",
>> -		.owner = THIS_MODULE,
>>  		.of_match_table = hdmi_of_match,
>>  	},
>>  	.probe = sti_hdmi_probe,
>> -- 
>> 2.34.1
>>
> 
> Acked-by: Alain Volmat <alain.volmat@foss.st.com>

What does this ack mean? You are the maintainer, so what is supposed to
happen now? If maintainer does not take patches, then the DRM STI looks
orphaned.

Best regards,
Krzysztof

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Krzysztof Kozlowski]

On 04/06/2024 15:18, Krzysztof Kozlowski wrote:
> On 27/05/2024 16:47, Alain Volmat wrote:
>> Hi Krzysztof,
>>
>> thanks for your patch, sorry for the delay.
>>
>> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
>>> Core in platform_driver_register() already sets the .owner, so driver
>>> does not need to.  Whatever is set here will be anyway overwritten by
>>> main driver calling platform_driver_register().
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>
>>> I forgot two drivers.
>>>  drivers/gpu/drm/sti/sti_hdmi.c | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
>>> index 500936d5743c..b0d84440a87b 100644
>>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
>>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
>>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>>>  struct platform_driver sti_hdmi_driver = {
>>>  	.driver = {
>>>  		.name = "sti-hdmi",
>>> -		.owner = THIS_MODULE,
>>>  		.of_match_table = hdmi_of_match,
>>>  	},
>>>  	.probe = sti_hdmi_probe,
>>> -- 
>>> 2.34.1
>>>
>>
>> Acked-by: Alain Volmat <alain.volmat@foss.st.com>
> 
> What does this ack mean? You are the maintainer, so what is supposed to
> happen now? If maintainer does not take patches, then the DRM STI looks
> orphaned.

+Cc Neil, Dmitry,

I pinged and pinged and wanted some sort of clarification here but one
month passed and nothing was clarified.

I could be understanding the DRM process wrong, but if no one picks up
trivial cleanups for 1.5 months, then to me subsystem is orphaned. I
will send respective MAINTAINERS update.

Best regards,
Krzysztof

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Neil Armstrong]

On 05/07/2024 11:59, Krzysztof Kozlowski wrote:
> On 04/06/2024 15:18, Krzysztof Kozlowski wrote:
>> On 27/05/2024 16:47, Alain Volmat wrote:
>>> Hi Krzysztof,
>>>
>>> thanks for your patch, sorry for the delay.
>>>
>>> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
>>>> Core in platform_driver_register() already sets the .owner, so driver
>>>> does not need to.  Whatever is set here will be anyway overwritten by
>>>> main driver calling platform_driver_register().
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>>
>>>> I forgot two drivers.
>>>>   drivers/gpu/drm/sti/sti_hdmi.c | 1 -
>>>>   1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
>>>> index 500936d5743c..b0d84440a87b 100644
>>>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
>>>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
>>>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>>>>   struct platform_driver sti_hdmi_driver = {
>>>>   	.driver = {
>>>>   		.name = "sti-hdmi",
>>>> -		.owner = THIS_MODULE,
>>>>   		.of_match_table = hdmi_of_match,
>>>>   	},
>>>>   	.probe = sti_hdmi_probe,
>>>> -- 
>>>> 2.34.1
>>>>
>>>
>>> Acked-by: Alain Volmat <alain.volmat@foss.st.com>
>>
>> What does this ack mean? You are the maintainer, so what is supposed to
>> happen now? If maintainer does not take patches, then the DRM STI looks
>> orphaned.
> 
> +Cc Neil, Dmitry,
> 
> I pinged and pinged and wanted some sort of clarification here but one
> month passed and nothing was clarified.
> 
> I could be understanding the DRM process wrong, but if no one picks up
> trivial cleanups for 1.5 months, then to me subsystem is orphaned. I
> will send respective MAINTAINERS update.

Let's do that, if Alain doesn't take his own patches that were reviewed
then it should either be orphaned  or moved to drm-misc.

Neil

> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Dmitry Baryshkov]

On Fri, 5 Jul 2024 at 13:04, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> On 05/07/2024 11:59, Krzysztof Kozlowski wrote:
> > On 04/06/2024 15:18, Krzysztof Kozlowski wrote:
> >> On 27/05/2024 16:47, Alain Volmat wrote:
> >>> Hi Krzysztof,
> >>>
> >>> thanks for your patch, sorry for the delay.
> >>>
> >>> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
> >>>> Core in platform_driver_register() already sets the .owner, so driver
> >>>> does not need to.  Whatever is set here will be anyway overwritten by
> >>>> main driver calling platform_driver_register().
> >>>>
> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>> ---
> >>>>
> >>>> I forgot two drivers.
> >>>>   drivers/gpu/drm/sti/sti_hdmi.c | 1 -
> >>>>   1 file changed, 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> >>>> index 500936d5743c..b0d84440a87b 100644
> >>>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> >>>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> >>>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
> >>>>   struct platform_driver sti_hdmi_driver = {
> >>>>    .driver = {
> >>>>            .name = "sti-hdmi",
> >>>> -          .owner = THIS_MODULE,
> >>>>            .of_match_table = hdmi_of_match,
> >>>>    },
> >>>>    .probe = sti_hdmi_probe,
> >>>> --
> >>>> 2.34.1
> >>>>
> >>>
> >>> Acked-by: Alain Volmat <alain.volmat@foss.st.com>
> >>
> >> What does this ack mean? You are the maintainer, so what is supposed to
> >> happen now? If maintainer does not take patches, then the DRM STI looks
> >> orphaned.
> >
> > +Cc Neil, Dmitry,
> >
> > I pinged and pinged and wanted some sort of clarification here but one
> > month passed and nothing was clarified.
> >
> > I could be understanding the DRM process wrong, but if no one picks up
> > trivial cleanups for 1.5 months, then to me subsystem is orphaned. I
> > will send respective MAINTAINERS update.
>
> Let's do that, if Alain doesn't take his own patches that were reviewed
> then it should either be orphaned  or moved to drm-misc.

But it already a part of drm-misc as far as I can see:

DRM DRIVERS FOR STI
M:      Alain Volmat <alain.volmat@foss.st.com>
L:      dri-devel@lists.freedesktop.org
S:      Maintained
T:      git https://gitlab.freedesktop.org/drm/misc/kernel.git
F:      Documentation/devicetree/bindings/display/st,stih4xx.txt
F:      drivers/gpu/drm/sti

-- 
With best wishes
Dmitry

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Krzysztof Kozlowski]

On 05/07/2024 12:37, Dmitry Baryshkov wrote:
>>>>> Acked-by: Alain Volmat <alain.volmat@foss.st.com>
>>>>
>>>> What does this ack mean? You are the maintainer, so what is supposed to
>>>> happen now? If maintainer does not take patches, then the DRM STI looks
>>>> orphaned.
>>>
>>> +Cc Neil, Dmitry,
>>>
>>> I pinged and pinged and wanted some sort of clarification here but one
>>> month passed and nothing was clarified.
>>>
>>> I could be understanding the DRM process wrong, but if no one picks up
>>> trivial cleanups for 1.5 months, then to me subsystem is orphaned. I
>>> will send respective MAINTAINERS update.
>>
>> Let's do that, if Alain doesn't take his own patches that were reviewed
>> then it should either be orphaned  or moved to drm-misc.
> 
> But it already a part of drm-misc as far as I can see:

In such case who is going to pick up such patches?

Best regards,
Krzysztof

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]

+Alain

On Tue, Jun 04, 2024 at 03:18:55PM GMT, Krzysztof Kozlowski wrote:
> On 27/05/2024 16:47, Alain Volmat wrote:
> > Hi Krzysztof,
> > 
> > thanks for your patch, sorry for the delay.
> > 
> > On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
> >> Core in platform_driver_register() already sets the .owner, so driver
> >> does not need to.  Whatever is set here will be anyway overwritten by
> >> main driver calling platform_driver_register().
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >>
> >> I forgot two drivers.
> >>  drivers/gpu/drm/sti/sti_hdmi.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> >> index 500936d5743c..b0d84440a87b 100644
> >> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> >> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> >> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
> >>  struct platform_driver sti_hdmi_driver = {
> >>  	.driver = {
> >>  		.name = "sti-hdmi",
> >> -		.owner = THIS_MODULE,
> >>  		.of_match_table = hdmi_of_match,
> >>  	},
> >>  	.probe = sti_hdmi_probe,
> >> -- 
> >> 2.34.1
> >>
> > 
> > Acked-by: Alain Volmat <alain.volmat@foss.st.com>
> 
> What does this ack mean? You are the maintainer, so what is supposed to
> happen now? If maintainer does not take patches, then the DRM STI looks
> orphaned.

The expectation would have been that Alain would have applied these
patches. That being said, your reply here dropped him from the
recipients list, so it's not surprising you didn't get any answer.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

[Krzysztof Kozlowski]

On 05/07/2024 13:14, Maxime Ripard wrote:
> +Alain
> 
> On Tue, Jun 04, 2024 at 03:18:55PM GMT, Krzysztof Kozlowski wrote:
>> On 27/05/2024 16:47, Alain Volmat wrote:
>>> Hi Krzysztof,
>>>
>>> thanks for your patch, sorry for the delay.
>>>


...

>>>
>>> Acked-by: Alain Volmat <alain.volmat@foss.st.com>
>>
>> What does this ack mean? You are the maintainer, so what is supposed to
>> happen now? If maintainer does not take patches, then the DRM STI looks
>> orphaned.
> 
> The expectation would have been that Alain would have applied these
> patches. That being said, your reply here dropped him from the
> recipients list, so it's not surprising you didn't get any answer.


Uh, indeed. I don't know how this happened. I was replying to him, which
is visible in "On 27/05 .... Alain Vormat wrote" header, but... weird.

Alain,
I apologize, it seems I am responsible for this mishap here.

Best regards,
Krzysztof

Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

[Krzysztof Kozlowski]

On 30/03/2024 21:38, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

It has been almost a month. Any comments? Anything is happening here?

Best regards,
Krzysztof

Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

[Alain Volmat]

Hi Krzysztof,

sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:28PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpu/drm/sti/sti_dvo.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
> index fd1df4ce3852..00502889c7f4 100644
> --- a/drivers/gpu/drm/sti/sti_dvo.c
> +++ b/drivers/gpu/drm/sti/sti_dvo.c
> @@ -581,7 +581,6 @@ MODULE_DEVICE_TABLE(of, dvo_of_match);
>  struct platform_driver sti_dvo_driver = {
>  	.driver = {
>  		.name = "sti-dvo",
> -		.owner = THIS_MODULE,
>  		.of_match_table = dvo_of_match,
>  	},
>  	.probe = sti_dvo_probe,
> -- 
> 2.34.1
> 

Acked-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

[Maxime Ripard]

On Sat, 30 Mar 2024 21:38:28 +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.  Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
> 
> 

Applied to misc/kernel.git (drm-misc-next).

Thanks!
Maxime