* [PATCH] cgroup: Fix typo in comment
@ 2022-11-20 15:51 haifeng.xu
2022-11-20 16:25 ` James Bottomley
2022-11-20 16:38 ` Kamalesh Babulal
0 siblings, 2 replies; 4+ messages in thread
From: haifeng.xu @ 2022-11-20 15:51 UTC (permalink / raw)
To: tj; +Cc: lizefan.x, hannes, cgroups, linux-kernel, haifeng.xu
Replace iff with if.
Signed-off-by: haifeng.xu <haifeng.xu@shopee.com>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index f2743a476190..93c5e50b1392 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -814,7 +814,7 @@ static bool css_set_populated(struct css_set *cset)
* One of the css_sets associated with @cgrp is either getting its first
* task or losing the last. Update @cgrp->nr_populated_* accordingly. The
* count is propagated towards root so that a given cgroup's
- * nr_populated_children is zero iff none of its descendants contain any
+ * nr_populated_children is zero if none of its descendants contain any
* tasks.
*
* @cgrp's interface file "cgroup.populated" is zero if both
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cgroup: Fix typo in comment
2022-11-20 15:51 [PATCH] cgroup: Fix typo in comment haifeng.xu
@ 2022-11-20 16:25 ` James Bottomley
2022-11-20 16:38 ` Kamalesh Babulal
1 sibling, 0 replies; 4+ messages in thread
From: James Bottomley @ 2022-11-20 16:25 UTC (permalink / raw)
To: haifeng.xu, tj; +Cc: lizefan.x, hannes, cgroups, linux-kernel
On Sun, 2022-11-20 at 15:51 +0000, haifeng.xu wrote:
> Replace iff with if.
You can't do this without a more detailed analysis. iff means if and
only if (logical implies in both directions), which appears to be more
correct in the code being patched than if, which is logical implies in
only one direction only.
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cgroup: Fix typo in comment
2022-11-20 15:51 [PATCH] cgroup: Fix typo in comment haifeng.xu
2022-11-20 16:25 ` James Bottomley
@ 2022-11-20 16:38 ` Kamalesh Babulal
2022-11-21 2:01 ` Haifeng Xu
1 sibling, 1 reply; 4+ messages in thread
From: Kamalesh Babulal @ 2022-11-20 16:38 UTC (permalink / raw)
To: haifeng.xu, tj; +Cc: lizefan.x, hannes, cgroups, linux-kernel
On 11/20/22 21:21, haifeng.xu wrote:
> Replace iff with if.
>
> Signed-off-by: haifeng.xu <haifeng.xu@shopee.com>
> ---
> kernel/cgroup/cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index f2743a476190..93c5e50b1392 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -814,7 +814,7 @@ static bool css_set_populated(struct css_set *cset)
> * One of the css_sets associated with @cgrp is either getting its first
> * task or losing the last. Update @cgrp->nr_populated_* accordingly. The
> * count is propagated towards root so that a given cgroup's
> - * nr_populated_children is zero iff none of its descendants contain any
> + * nr_populated_children is zero if none of its descendants contain any
> * tasks.
> *
> * @cgrp's interface file "cgroup.populated" is zero if both
iff abbreviates to if and only if and it's a valid usage.
--
Thanks,
Kamalesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cgroup: Fix typo in comment
2022-11-20 16:38 ` Kamalesh Babulal
@ 2022-11-21 2:01 ` Haifeng Xu
0 siblings, 0 replies; 4+ messages in thread
From: Haifeng Xu @ 2022-11-21 2:01 UTC (permalink / raw)
To: Kamalesh Babulal, tj; +Cc: lizefan.x, hannes, cgroups, linux-kernel
On 2022/11/21 00:38, Kamalesh Babulal wrote:
>
>
> On 11/20/22 21:21, haifeng.xu wrote:
>> Replace iff with if.
>>
>> Signed-off-by: haifeng.xu <haifeng.xu@shopee.com>
>> ---
>> kernel/cgroup/cgroup.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
>> index f2743a476190..93c5e50b1392 100644
>> --- a/kernel/cgroup/cgroup.c
>> +++ b/kernel/cgroup/cgroup.c
>> @@ -814,7 +814,7 @@ static bool css_set_populated(struct css_set *cset)
>> * One of the css_sets associated with @cgrp is either getting its first
>> * task or losing the last. Update @cgrp->nr_populated_* accordingly. The
>> * count is propagated towards root so that a given cgroup's
>> - * nr_populated_children is zero iff none of its descendants contain any
>> + * nr_populated_children is zero if none of its descendants contain any
>> * tasks.
>> *
>> * @cgrp's interface file "cgroup.populated" is zero if both
>
> iff abbreviates to if and only if and it's a valid usage.
>
Ok, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-21 2:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-20 15:51 [PATCH] cgroup: Fix typo in comment haifeng.xu
2022-11-20 16:25 ` James Bottomley
2022-11-20 16:38 ` Kamalesh Babulal
2022-11-21 2:01 ` Haifeng Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®