* Re: [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg()
2023-06-11 20:44 [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg() Christophe JAILLET
@ 2023-06-12 4:47 ` Pavan Chebbi
2023-06-12 5:18 ` [Intel-wired-lan] " Keller, Jacob E
2023-06-12 6:23 ` Paul Menzel
2 siblings, 0 replies; 4+ messages in thread
From: Pavan Chebbi @ 2023-06-12 4:47 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-kernel, kernel-janitors,
intel-wired-lan, netdev
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Mon, Jun 12, 2023 at 2:14 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> There is no need to use managed memory allocation here. The memory is
> released at the end of the function.
>
> You kzalloc()/kfree() to simplify the code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/intel/ice/ice_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index eb2dc0983776..4b799a5d378a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -834,7 +834,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
> u16 size;
>
> size = sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX;
> - config = devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL);
> + config = kzalloc(size, GFP_KERNEL);
> if (!config)
> return -ENOMEM;
>
> @@ -857,7 +857,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
> }
> }
>
> - devm_kfree(ice_hw_to_dev(hw), config);
> + kfree(config);
>
> return status;
> }
> --
> 2.34.1
>
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg()
2023-06-11 20:44 [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg() Christophe JAILLET
2023-06-12 4:47 ` Pavan Chebbi
@ 2023-06-12 5:18 ` Keller, Jacob E
2023-06-12 6:23 ` Paul Menzel
2 siblings, 0 replies; 4+ messages in thread
From: Keller, Jacob E @ 2023-06-12 5:18 UTC (permalink / raw)
To: Christophe JAILLET, Brandeburg, Jesse, Nguyen, Anthony L,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: intel-wired-lan, kernel-janitors, linux-kernel, netdev
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Christophe JAILLET
> Sent: Sunday, June 11, 2023 1:44 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>; intel-wired-
> lan@lists.osuosl.org; kernel-janitors@vger.kernel.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ice: Remove managed memory usage
> in ice_get_fw_log_cfg()
>
> There is no need to use managed memory allocation here. The memory is
> released at the end of the function.
>
> You kzalloc()/kfree() to simplify the code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Agreed.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> drivers/net/ethernet/intel/ice/ice_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c
> b/drivers/net/ethernet/intel/ice/ice_common.c
> index eb2dc0983776..4b799a5d378a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -834,7 +834,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
> u16 size;
>
> size = sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX;
> - config = devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL);
> + config = kzalloc(size, GFP_KERNEL);
> if (!config)
> return -ENOMEM;
>
> @@ -857,7 +857,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
> }
> }
>
> - devm_kfree(ice_hw_to_dev(hw), config);
> + kfree(config);
>
> return status;
> }
> --
> 2.34.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg()
2023-06-11 20:44 [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg() Christophe JAILLET
2023-06-12 4:47 ` Pavan Chebbi
2023-06-12 5:18 ` [Intel-wired-lan] " Keller, Jacob E
@ 2023-06-12 6:23 ` Paul Menzel
2 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2023-06-12 6:23 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, intel-wired-lan, kernel-janitors,
linux-kernel, netdev
Dear Christophe,
Thank you for the patch.
Am 11.06.23 um 22:44 schrieb Christophe JAILLET:
> There is no need to use managed memory allocation here. The memory is
> released at the end of the function.
>
> You kzalloc()/kfree() to simplify the code.
s/You/Use/?
Kind regards,
Paul
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/intel/ice/ice_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index eb2dc0983776..4b799a5d378a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -834,7 +834,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
> u16 size;
>
> size = sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX;
> - config = devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL);
> + config = kzalloc(size, GFP_KERNEL);
> if (!config)
> return -ENOMEM;
>
> @@ -857,7 +857,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
> }
> }
>
> - devm_kfree(ice_hw_to_dev(hw), config);
> + kfree(config);
>
> return status;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread