From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
andre.draszik@linaro.org, kernel-team@android.com,
willmcvicker@google.com, peter.griffin@linaro.org,
daniel.lezcano@linaro.org, vincent.guittot@linaro.org,
ulf.hansson@linaro.org, arnd@arndb.de
Subject: Re: [PATCH v5 2/3] firmware: add Exynos ACPM protocol driver
Date: Thu, 16 Jan 2025 11:41:42 +0000 [thread overview]
Message-ID: <77eeed18-4a48-4407-ae83-7a922045b29a@linaro.org> (raw)
In-Reply-To: <060c7a96-c1ed-4c97-8a3f-f510102466f9@linaro.org>
On 12/31/24 2:32 PM, Tudor Ambarus wrote:
>>> +config EXYNOS_ACPM_PROTOCOL
>>> + tristate "Exynos Alive Clock and Power Manager (ACPM) Message Protocol"
>>> + depends on ARCH_EXYNOS || COMPILE_TEST
>>> + depends on EXYNOS_MBOX
>> Is it build time dependency? No || COMPILE_TEST?
> There's no build time dependency, I'll drop this line.
There's no build time dependency on EXYNOS_MBOX, but there is on MAILBOX:
ERROR: modpost: "mbox_request_channel"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_free_channel"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_send_message"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_client_txdone"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
Will replace the line with "depends on MAILBOX".
Thanks!
ta
next prev parent reply other threads:[~2025-01-16 11:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 14:32 [PATCH v5 0/3] " Tudor Ambarus
2024-12-20 14:32 ` [PATCH v5 1/3] dt-bindings: firmware: add google,gs101-acpm-ipc Tudor Ambarus
2024-12-22 8:48 ` Krzysztof Kozlowski
2024-12-20 14:32 ` [PATCH v5 2/3] firmware: add Exynos ACPM protocol driver Tudor Ambarus
2024-12-24 14:14 ` Krzysztof Kozlowski
2024-12-31 14:32 ` Tudor Ambarus
2025-01-06 9:33 ` Tudor Ambarus
2025-01-06 10:20 ` Tudor Ambarus
2025-01-07 10:50 ` Tudor Ambarus
2025-01-16 11:41 ` Tudor Ambarus [this message]
2024-12-20 14:32 ` [PATCH v5 3/3] MAINTAINERS: add entry for the Samsung Exynos ACPM mailbox protocol Tudor Ambarus
2024-12-22 8:47 ` [PATCH v5 0/3] firmware: add Exynos ACPM protocol driver Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77eeed18-4a48-4407-ae83-7a922045b29a@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®