Re: [PATCH 03/20] clocksource/drivers/vf_pit: Set the scene for multiple timers

[Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>]

On 7/5/2025 7:01 PM, Daniel Lezcano wrote:
> The driver is implemented as using a single timer and a single
> clocksource. In order to take advantage of the multiple timers
> supported in the PIT hardware and introduce different setup for a new
> platform, let's encapsulate the data into a structure and pass this
> structure around in the function parameter. The structure will be a
> per timer instanciation in the next changes.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/clocksource/timer-vf-pit.c | 119 +++++++++++++++++------------
>  1 file changed, 70 insertions(+), 49 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
> index 8041a8f62d1f..581b46e7b111 100644
> --- a/drivers/clocksource/timer-vf-pit.c
> +++ b/drivers/clocksource/timer-vf-pit.c
> @@ -15,7 +15,7 @@
>   */
>  #define PITMCR		0x00
>  #define PIT0_OFFSET	0x100
> -#define PITn_OFFSET(n)	(PIT0_OFFSET + 0x10 * (n))
> +#define PIT_CH(n)       (PIT0_OFFSET + 0x10 * (n))
>  #define PITLDVAL	0x00
>  #define PITCVAL		0x04
>  #define PITTCTRL	0x08

While not directly part of this change, the description above this patch states: 'Each PIT takes 0x10 bytes of register space.' In my view, this is somewhat misleading, as the reference manual refers to them as channels rather than separate PIT instances.

-- 
Regards,
Ghennadi